Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"The peers list" heading in IPFS needs rewording #16129

Closed
Tracked by #17112
stephendonner opened this issue May 28, 2021 · 1 comment · Fixed by brave/brave-core#9005
Closed
Tracked by #17112

"The peers list" heading in IPFS needs rewording #16129

stephendonner opened this issue May 28, 2021 · 1 comment · Fixed by brave/brave-core#9005
Assignees
@spylogsster
Labels
feature/web3/ipfs OS/Desktop QA Pass-macOS QA/Yes release-notes/exclude
Milestone
1.27.x - Release

Comments

@stephendonner
Copy link

Description

"The peers list" heading in IPFS needs rewording

Steps to Reproduce

  1. new profile, launch Brave
  2. load ipns://brantly.eth
  3. click on Use a local node
  4. load brave://settings/ipfs/peers
  5. beneath Modify the peers list, read the text

Actual result:

The peers list seems a bit awkward

Screen Shot 2021-05-28 at 9 02 57 AM

Expected result:

Peers list or simply Peers?

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.27.26 Chromium: 91.0.4472.77 (Official Build) nightly (x86_64)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS macOS Version 11.4 (Build 20F71)

/cc @karenkliu @rebron
@spylogsster spylogsster mentioned this issue Jun 3, 2021
Merged
24 tasks
@spylogsster spylogsster self-assigned this Jun 3, 2021
@bbondy bbondy added this to the 1.27.x - Nightly milestone Jun 4, 2021
@stephendonner
Copy link
Author

Verified FIXED using the inline testplan with build

Brave 1.27.45 Chromium: 91.0.4472.88 (Official Build) nightly (x86_64)
Revision 109e9cd038b94a631aea7d40ee3d56c1278f2597-refs/branch-heads/4472@{#1385}
OS macOS Version 11.4 (Build 20F71)

Screen Shot 2021-06-07 at 10 51 25 AM

@rebron rebron mentioned this issue Jul 23, 2021
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spylogsster spylogsster

Labels
feature/web3/ipfs OS/Desktop QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.27.x - Release
Development

Successfully merging a pull request may close this issue.

Removed duplicated peers list title brave/brave-core
4 participants
@stephendonner @bbondy @spylogsster @rebron