Fix TLS pins and update list of pinned roots #8750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tmancey Does this cover all of the Ads and Rewards endpoints? (i.e. does it fix brave/brave-browser#12349?) |
|
Note on testing: since browser tests don't have access to the network, I'm not able to browse to the test page with a bad cert and verify that the pinset is actually working. The best I could do is fake the TLS state and look for an interstitial, but whether or not that state gets set is what I'm most interested in testing. There is also an open request for a Brave-specific domain that will allow us to do a full end-to-end (manual) test: https://github.com/brave/devops/issues/4981 |
mkarolin
reviewed
May 10, 2021
fmarier
force-pushed
the
update-pins-14637
branch
2 times, most recently
from
cd72e8d
to
7ac6fe9
Compare
bridiver
reviewed
May 13, 2021
bridiver
reviewed
May 13, 2021
fmarier
force-pushed
the
update-pins-14637
branch
2 times, most recently
from
6a97a1d
to
964f9e7
Compare
fmarier
force-pushed
the
update-pins-14637
branch
6 times, most recently
from
56b35a7
to
8a1aed7
Compare
…14637) This removes deprecated/expired roots and adds all currently active ones: https://support.globalsign.com/ca-certificates/root-certificates/globalsign-root-certificates https://letsencrypt.org/certificates/#root-certificates
https://www.identrust.com/support/downloads This is still used for Let's Encrypt certificates on some of our servers, though it will expire in September 2021: https://letsencrypt.org/docs/dst-root-ca-x3-expiration-september-2021/
These hostnames are related to updates and stats and so we want to make sure that all clients can reach them even in the presence of interfering middle boxes or bugs in pinning implementation.
fmarier
force-pushed
the
update-pins-14637
branch
from
8a1aed7
to
4af1c2c
Compare
bridiver
approved these changes
May 28, 2021
|
The Android build failure is a known one since it's currently failing on Nightly: https://bravesoftware.slack.com/archives/CA5FPHWLF/p1622162074079200 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#15667,
Resolves brave/brave-browser#14637,
Resolves brave/brave-browser#12349,
Resolves brave/brave-browser#2949,
Resolves brave/brave-browser#15874
Security review: https://github.com/brave/security/issues/446
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
"Cannot GET /"and that's okay).