[Security][Android] SSL Pinning doesn't work

[stoletheminerals]

Description

SSL Pinning doesn't work for the domains listed in https://github.com/brave/brave-core/blob/master/chromium_src/net/tools/transport_security_state_generator/input_file_parsers.cc

Steps to reproduce

1. Navigate to https://ssl-pinning.someblog.org/

Actual result

Webpage loads without an SSL error

Expected result

Webpage fails to load with an SSL error

Issue reproduces how often

Version/Channel Information:

• Can you reproduce this issue with the current Play Store version?
• Can you reproduce this issue with the current Play Store Beta version?
• Can you reproduce this issue with the current Play Store Nightly version?

Device details

• Install type (ARM, x86):
• Device type (Phone, Tablet, Phablet):
• Android version:

Brave version

Website problems only

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Additional information

[fmarier]

Upstream appears to be preparing to roll this out to Android: https://chromium.googlesource.com/chromium/src/+/f12eac9342eb88971851d46e31c97af8c2c27%5E%21/

[fmarier]

This is now working in Brave for Android and so we should enable too.

This was done on desktop in brave/brave-core#8750.

[fmarier]

It's probably just a matter of removing the check for Android here: https://github.com/brave/brave-core/blob/44a98b1a20d935db5eab9899361871740695d29b/chromium_src/net/http/transport_security_state.cc#L17-L25

and then testing it like this:

1. Going through the test plan at Update pinned roots brave-core#22540
2. Opening https://pinning-test.badssl.com/ and confirming that there's no TLS error and that the red page loads fine:
   

[hffvld]

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 15 AP31.240517.031 release-keys
Brave build: 1.68.115
Chromium: 127.0.6533.26 (Official Build) beta (64-bit) 

---

STEPS:

1. Follow the STR/TP from [Security][Android] SSL Pinning doesn't work  #24453 (comment) and [Security][Android] SSL Pinning doesn't work  #24453 (comment)
2. Verify

ACTUAL RESULTS:

• Verified that the page fails to load with an SSL error when navigating to https://ssl-pinning.someblog.org/
• Verified that there's no TLS error and that the red page loads fine when navigating to https://pinning-test.badssl.com/

---

1	2