Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cname url when blocking #8262

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Use cname url when blocking #8262

merged 1 commit into from
Mar 16, 2021

Conversation

antonok-edm
Copy link
Collaborator

@antonok-edm antonok-edm commented Mar 16, 2021

Resolves brave/brave-browser#14756

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • visit https://pushbullet.com (there should be 1 request being blocked
  • add the following custom filer via brave://adblock
||stripecdn.map.fastly.net^$important
||d2rhbqunra2aep.cloudfront.net^$important
  • once the above custom filter has been applied, visit https://pushbullet.com (there should be 2 requests blocked)

@antonok-edm antonok-edm requested a review from darkdh March 16, 2021 05:11
@antonok-edm antonok-edm self-assigned this Mar 16, 2021
@antonok-edm antonok-edm requested a review from iefremov as a code owner March 16, 2021 05:11
@antonok-edm antonok-edm merged commit 9e2f14a into master Mar 16, 2021
@antonok-edm antonok-edm deleted the cname-block-regression branch March 16, 2021 15:36
brave-builds pushed a commit that referenced this pull request Mar 16, 2021
brave-builds pushed a commit that referenced this pull request Mar 16, 2021
@antonok-edm antonok-edm added this to the 1.23.x - Beta milestone Mar 17, 2021
@kjozwiak
Copy link
Member

Verification PASSED on macOS 11.2.3 x64 using the following build:

Brave | 1.24.2 Chromium: 89.0.4389.90 (Official Build) nightly (x86_64)
--- | ---
Revision | 62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS | macOS Version 11.2.3 (Build 20D91)
Using custom Filters Using custom Filters Using custom Filters
Screen Shot 2021-03-17 at 3 02 33 PM Screen Shot 2021-03-17 at 3 02 41 PM image

Verification PASSED on Samsung S10+ running Android 11 using the following build:

1.24.2 Chromium: 89.0.4389.90

Using Mobile Website

Using custom Filters Using custom Filters
Screenshot_20210317-161013_Brave - Nightly Screenshot_20210317-161019_Brave - Nightly

Using Desktop Website

Using custom Filters Using custom Filters
Screenshot_20210317-161454_Brave - Nightly Screenshot_20210317-161447_Brave - Nightly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix regression in CNAME uncloaking
4 participants