Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTP: Fix customize popup background via missing semi-colon to css #8261

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

petemill
Copy link
Member

Likely culprit was upgraded version of styled-components being more strict when generating css output.

Resolves brave/brave-browser#14754

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Likely culprit was upgraded version of styled-components being more strict when generating css output.
@petemill petemill self-assigned this Mar 16, 2021
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton added this to the 1.23.x - Nightly milestone Mar 16, 2021
@bsclifton bsclifton merged commit 15569c6 into master Mar 16, 2021
@bsclifton bsclifton deleted the ntp-customize-background-fix branch March 16, 2021 18:25
@stephendonner
Copy link
Contributor

stephendonner commented Mar 17, 2021

Verified PASSED using nightly build

Brave 1.24.1 Chromium: 89.0.4389.90 (Official Build) nightly (x86_64)
Revision 62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS macOS Version 11.2.3 (Build 20D91)

Screen Shot 2021-03-16 at 8 28 25 PMScreen Shot 2021-03-17 at 9 32 30 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] Customize window on NTP appears transparent in Nightly (v1.23.36)
3 participants