Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8049: Never send header with variations. #7886

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Conversation

iefremov
Copy link
Contributor

@iefremov iefremov commented Feb 9, 2021

Fix brave/brave-browser#8049

Submitter Checklist:

  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)
  • Requested a security/privacy review as needed

Reviewer Checklist:

  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See brave/brave-browser#8049

@iefremov iefremov requested a review from a team as a code owner February 9, 2021 11:43
@iefremov iefremov self-assigned this Feb 9, 2021
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chromium_src LGTM.

@iefremov iefremov merged commit 0a99c86 into master Feb 12, 2021
@iefremov iefremov deleted the ie_variations_header branch February 12, 2021 15:09
@iefremov iefremov added this to the 1.22.x - Nightly milestone Feb 12, 2021
@bsclifton
Copy link
Member

❤️

@kjozwiak
Copy link
Member

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.22.28 Chromium: 89.0.4389.48 (Official Build) nightly (64-bit)
-- | --
Revision | 0fe3c4589a6cf5ce719d167834dfa9cd8978937a-refs/branch-heads/4389@{#873}
OS | Windows 10 OS Version 2009 (Build 19042.804)
Before Fix (YT) Before Fix (GCal)
beforeFix beforeFix2
After Fix (YT) After Fix (GCal)
afterfix2 afterfix1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x-client-data header should not be sent in requests
4 participants