Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8049: Never send header with variations. (uplift to 1.20.x) #7951

Merged
merged 1 commit into from
Feb 16, 2021
Merged

8049: Never send header with variations. (uplift to 1.20.x) #7951

merged 1 commit into from
Feb 16, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Feb 12, 2021 •
edited by kjozwiak
Loading

Uplift of #7886
Fix brave/brave-browser#8049

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner February 12, 2021 17:24
@brave-builds brave-builds requested a review from a team February 12, 2021 17:24
@brave-builds brave-builds self-assigned this Feb 12, 2021
@brave-builds brave-builds added this to the 1.20.x - Release #2 milestone Feb 12, 2021
@kjozwiak
Copy link
Member

Restarting macOS as build failed as per https://ci.brave.com/job/pr-brave-browser-pr7886_ie_variations_header_1.20.x-macos/1/execution/node/162/log/.

13:48:11  FAILED: obj/brave/browser/ui/bookmark/bookmark/brave_bookmark_tab_helper.o

kjozwiak
kjozwiak approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.20.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #7886 (comment).

@kjozwiak kjozwiak merged commit e3b6ee5 into 1.20.x Feb 16, 2021
@kjozwiak kjozwiak deleted the pr7886_ie_variations_header_1.20.x branch February 16, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.20.x - Release #2
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @brave-browser-releases