Fix re-appearing unwanted components #7496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unwanted components on brave://components have re-appeared. This commit adds some logging to find out whether our override that should prevent them gets called.
mherrmann
force-pushed
the
mherrmann-fix-bb-8709
branch
from
8b39d55
to
3aa12b9
Compare
bridiver
approved these changes
Dec 28, 2020
mherrmann
changed the title
|
Checked in Nightly v1.20.48 that this PR worked. On Linux with an empty profile, the components are not there:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#8709.
The unwanted components on brave://components have re-appeared. The reason is that I introduced a bug when I implemented a suggestion by a reviewer on my original PR without thinking.
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed).Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on.
Test Plan:
Open
brave://componentson Windows, Mac, Linux and Android and check that none of the components described in brave/brave-browser#8709 (comment) are visible. The only exception is CRLSet on Android which @pj said should actually be there.