Remove unsupported components in brave://components #8709

jumde · 2020-03-16T17:32:26Z

Description

Components like MEI preload, Legacy TLS Deprecation Configuration and Origin Trials are not supported by Brave. We should clean up the list to only list components supported by Brave.

Steps to Reproduce

Navigate to brave://components

Actual result:

Unsupported components are displayed.

Expected result:

Should not be displayed

Reproduces how often:

Easily

Brave version (brave://version info)

1.4.96 Chromium: 80.0.3987.132 (Official Build) (64-bit)

Version/Channel Information:

All Channels

mherrmann · 2020-12-02T17:59:42Z

mherrmann · 2020-12-02T18:18:49Z

An interesting first finding is that Chromium's source code doesn't mention the IDs I quoted above, except in comments. For example safety_tips_component_installer.cc:

// The SHA256 of the SubjectPublicKeyInfo used to sign the extension.
// The extension id is: jflookgnkcckhobaglndicnbbgbonegd
const uint8_t kSafetyTipsPublicKeySHA256[32] = {
    0x95, 0xbe, 0xea, 0x6d, 0xa2, 0x2a, 0x7e, 0x10, 0x6b, 0xd3, 0x82,
    0xd1, 0x16, 0x1e, 0xd4, 0x63, 0x21, 0xfe, 0x79, 0x5d, 0x02, 0x30,
    0xc2, 0xcf, 0x4a, 0x9c, 0x8a, 0x39, 0xcc, 0x4a, 0x00, 0xce};

Per https://chromium.googlesource.com/chromium/src/+/lkgr/components/component_updater/README.md, the string jflookgnkcckhobaglndicnbbgbonegd can be obtained from this array by discarding the first half and rendering as hexadecimal using the characters a-p. For example: 0x95 becomes "the 10th char in abc...p followed by the 6th char in abc...p", which is jf.

It would be nice to have an implementation for blacklisting unwanted components in Brave that simply keeps a list of the string ids jflookgnkcckhobaglndicnbbgbonegd. A logical place for this would be ComponentInstaller::Register, which is called from places like RegisterTLSDeprecationConfigComponent.

fmarier · 2020-12-22T23:41:56Z

Looks like this might be broken. I checked the latest nightly (Version 1.20.40 Chromium: 88.0.4315.5 (Official Build) nightly (64-bit)) and a fresh build of master and I can still see all of disabled 0.0.0.0 components.

mherrmann · 2020-12-23T06:18:42Z

I'm looking into it. From what I see so far, it appears as if the override in Brave that should prevent the components from being installed does not get called. The override blocks unwanted components by their ID. I already ruled out that those IDs have changed. Will update here as I obtain more info.

mherrmann · 2020-12-23T11:58:31Z

The override is called, even with the correct component IDs, but fails to identify them as disallowed. Still investigating.

mherrmann · 2020-12-23T17:59:28Z

Fixed in brave/brave-core#7496. @fmarier you could test the binaries there if you like.

mherrmann · 2020-12-29T06:17:32Z

Checked in Nightly v1.20.48 that my fix in brave/brave-core#7496 worked. On Linux with an empty profile, the components are not there:

fmarier · 2021-01-04T18:36:30Z

It works for me too (Nightly). Thanks for the follow-up fix!

mherrmann · 2021-01-05T05:58:59Z

Sure. Sorry for the initial bug.

LaurenWags · 2021-01-22T17:38:21Z

@fmarier @mherrmann @jumde I'm still seeing the following components from #8709 (comment) listed on brave://components in 1.20.x, however I believe this is expected per other issues in this milestone, correct?

Crowd Deny - expected per #13426
Certificate Error Assistant - expected per #13010
Safety Tips - expected per #12999

All other components listed have non-zero version numbers:

jumde · 2021-01-22T18:35:41Z

@LaurenWags - That is correct.

LaurenWags · 2021-01-25T12:56:26Z

Verified passed with

Brave | 1.20.88 Chromium: 88.0.4324.96 (Official Build) dev (x86_64)
-- | --
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS | macOS Version 10.15.7 (Build 19H15)

Verified components listed in #8709 (comment) are not shown on brave://components except for:

Crowd Deny - per #13426
Certificate Error Assistant - per #13010
Safety Tips - per #12999

All components listed on brave://components have non-zero version numbers:

Verification passed on


Brave | 1.20.88 Chromium: 88.0.4324.96 (Official Build) dev (64-bit)
-- | --
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS | Windows 10 OS Version 2004 (Build 19041.746)

Verified components listed in #8709 (comment) are not shown on brave://components

Verification passed on

Brave	1.20.88 Chromium: 88.0.4324.96 (Official Build) dev (64-bit)
Revision	68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS	Ubuntu 18.04 LTS

Verified components listed in #8709 (comment) are not shown on brave://components except for:

Crowd Deny - per #13426
Certificate Error Assistant - per #13010
Safety Tips - per #12999

All components listed on brave://components have non-zero version numbers:

GeetaSarvadnya · 2021-01-25T18:55:51Z

@fmarier @mherrmann @jumde In Windows 10 x64 - Dev build 1.20.88, I am seeing Hyphenation components. Is this expected? (I don't see this component in macOS)

fmarier · 2021-01-25T21:51:24Z

I am seeing Hyphenation components. Is this expected? (I don't see this component in macOS)

I'm not sure why it's not avaiable on Mac because I can also see it on Linux, but it is supposed to be enabled: https://bravesoftware.slack.com/archives/C8MP8ME4C/p1607477451338100?thread_ts=1607461532.330600&cid=C8MP8ME4C

I added it to the list on https://github.com/brave/brave-browser/wiki/Brave-Components.

LaurenWags · 2021-01-25T21:54:33Z

@jumde do you see Hyphenation on macOS, I do not.

jumde · 2021-01-25T22:06:37Z

No Hyphenation on macOS, will debug

rebron added feature/components OS/Desktop dev-concern labels May 1, 2020

srirambv changed the title ~~Remove unsupported components in brave://components~~ [Desktop] Remove unsupported components in brave://components Sep 9, 2020

This was referenced Nov 27, 2020

Fix failing component auto-updates brave/brave-core#7164

Merged

[Desktop] Review non-registered components #11544

Closed

mherrmann self-assigned this Dec 2, 2020

This was referenced Dec 3, 2020

Remove unsupported components from brave://components brave/brave-core#7331

Merged

Fix crowd-deny updates #10280

Closed

[Security] Enable Safety Tips #12999

Closed

Enable certificate error assistant #13010

Closed

mihaiplesa closed this as completed in brave/brave-core#7331 Dec 14, 2020

mihaiplesa added this to the 1.20.x - Nightly milestone Dec 14, 2020

mihaiplesa added the QA/Yes label Dec 16, 2020

LaurenWags mentioned this issue Dec 17, 2020

Stephen - QA hack day brave/qa-resources#199

Closed

jumde mentioned this issue Dec 19, 2020

Remove unused components from brave://components #10972

Closed

fmarier reopened this Dec 22, 2020

mherrmann mentioned this issue Dec 23, 2020

Fix re-appearing unwanted components brave/brave-core#7496

Merged

23 tasks

mherrmann closed this as completed in brave/brave-core#7496 Dec 28, 2020

mherrmann added the release-notes/include label Dec 28, 2020

LaurenWags added the QA/Blocked label Jan 22, 2021

LaurenWags removed the QA/Blocked label Jan 22, 2021

LaurenWags added the QA Pass-macOS label Jan 25, 2021

rebron changed the title ~~[Desktop] Remove unsupported components in brave://components~~ Remove unsupported components in brave://components Jan 25, 2021

GeetaSarvadnya added the QA Pass-Win64 label Jan 25, 2021

btlechowski added the QA Pass-Linux label Jan 26, 2021

LaurenWags mentioned this issue Feb 8, 2021

[Desktop] Release Notes for 1.20.x Release #1 (Release Channel) #14035

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove unsupported components in brave://components #8709

Remove unsupported components in brave://components #8709

jumde commented Mar 16, 2020

mherrmann commented Dec 2, 2020 •

edited

Loading

mherrmann commented Dec 2, 2020 •

edited

Loading

fmarier commented Dec 22, 2020

mherrmann commented Dec 23, 2020

mherrmann commented Dec 23, 2020

mherrmann commented Dec 23, 2020 •

edited

Loading

mherrmann commented Dec 29, 2020

fmarier commented Jan 4, 2021

mherrmann commented Jan 5, 2021

LaurenWags commented Jan 22, 2021

jumde commented Jan 22, 2021

LaurenWags commented Jan 25, 2021 •

edited by btlechowski

Loading

GeetaSarvadnya commented Jan 25, 2021 •

edited

Loading

fmarier commented Jan 25, 2021

LaurenWags commented Jan 25, 2021

jumde commented Jan 25, 2021

Remove unsupported components in brave://components #8709

Remove unsupported components in brave://components #8709

Comments

jumde commented Mar 16, 2020

Description

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

mherrmann commented Dec 2, 2020 • edited Loading

mherrmann commented Dec 2, 2020 • edited Loading

fmarier commented Dec 22, 2020

mherrmann commented Dec 23, 2020

mherrmann commented Dec 23, 2020

mherrmann commented Dec 23, 2020 • edited Loading

mherrmann commented Dec 29, 2020

fmarier commented Jan 4, 2021

mherrmann commented Jan 5, 2021

LaurenWags commented Jan 22, 2021

jumde commented Jan 22, 2021

LaurenWags commented Jan 25, 2021 • edited by btlechowski Loading

GeetaSarvadnya commented Jan 25, 2021 • edited Loading

fmarier commented Jan 25, 2021

LaurenWags commented Jan 25, 2021

jumde commented Jan 25, 2021

mherrmann commented Dec 2, 2020 •

edited

Loading

mherrmann commented Dec 2, 2020 •

edited

Loading

mherrmann commented Dec 23, 2020 •

edited

Loading

LaurenWags commented Jan 25, 2021 •

edited by btlechowski

Loading

GeetaSarvadnya commented Jan 25, 2021 •

edited

Loading