-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NTP Update #6681
NTP Update #6681
Conversation
4d7c9ec
to
bc5f6f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the same type of things should be done for gemini and binance widgets but those ones should be done in a separate PR.
Adding @petemill for review of the front end files.
chromium_src/chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc
Show resolved
Hide resolved
ed66643
to
bb0b275
Compare
bb0b275
to
71c3f38
Compare
71c3f38
to
4a0a01f
Compare
4a0a01f
to
5075ed5
Compare
5075ed5
to
b05991c
Compare
b05991c
to
9f50756
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New validation code not working, sorry
components/brave_new_tab_ui/components/default/bitcoinDotCom/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 👍
Verification passed on
Logged followup issues
|
Adding Bitcoin.com widget to the NTP
Fixes: https://github.com/brave/internal/issues/726
Submitter Checklist:
npm run lint
,npm run gn_check
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.