Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTP Update #6681

Merged
merged 16 commits into from
Oct 1, 2020
Merged

NTP Update #6681

merged 16 commits into from
Oct 1, 2020

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Sep 22, 2020

Fixes: https://github.com/brave/internal/issues/726

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added this to the 1.16.x - Nightly milestone Sep 22, 2020
@ryanml ryanml requested a review from bridiver as a code owner September 22, 2020 09:01
@ryanml ryanml self-assigned this Sep 22, 2020
@ryanml ryanml force-pushed the ntp-update-bdc branch 2 times, most recently from 4d7c9ec to bc5f6f7 Compare September 23, 2020 01:20
bbondy
bbondy previously requested changes Sep 23, 2020
Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the same type of things should be done for gemini and binance widgets but those ones should be done in a separate PR.

Adding @petemill for review of the front end files.

browser/BUILD.gn Outdated Show resolved Hide resolved
browser/brave_profile_prefs.cc Outdated Show resolved Hide resolved
common/pref_names.cc Outdated Show resolved Hide resolved
common/pref_names.h Outdated Show resolved Hide resolved
components/moonpay/buildflags/buildflags.gni Outdated Show resolved Hide resolved
browser/brave_profile_prefs.cc Outdated Show resolved Hide resolved
components/moonpay/browser/BUILD.gn Outdated Show resolved Hide resolved
@ryanml ryanml requested a review from petemill October 1, 2020 04:15
@ryanml ryanml dismissed petemill’s stale review October 1, 2020 04:15

addressed changes

Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New validation code not working, sorry

@ryanml ryanml requested a review from petemill October 1, 2020 06:01
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@ryanml ryanml modified the milestones: 1.16.x - Beta, 1.17.x - Nightly Oct 1, 2020
@ryanml ryanml dismissed bbondy’s stale review October 1, 2020 06:53

changes addressed

@ryanml ryanml merged commit 88ec69a into master Oct 1, 2020
@ryanml ryanml deleted the ntp-update-bdc branch October 1, 2020 07:49
@srirambv
Copy link
Contributor

srirambv commented Oct 2, 2020

Verification passed on

Brave 1.17.7 Chromium: 86.0.4240.55 (Official Build) nightly (64-bit)
Revision a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS macOS Version 10.15.7 (Build 19H2)/ Linux/ Windows 10 OS Version 1809 (Build 17763.1457)
  • Verified on a clean profile, opening NTP shows Bitcoin.com widget
    image

  • Verified by default the widget is stacked behind Binance widget
    image

  • Verified Bitcoin.com widget is available in Add cards settings and can be added or removed
    image

  • Verified default Fiat currency is set to EUR (EURO)
    image

  • Verified currency can be changed from default
    image

  • Verified amount only takes numerical/decimal values and doesn't accept any string input
    image

  • Verified clicking on the Buy button opens a landing page with the prepopulated value of the entered amount
    https://bitcoincom.moonpay.io/?currencyCode=ltc&baseCurrencyCode=aud&baseCurrencyAmount=100.53

  • Verified clicking on Get the wallet here to get started opens up https://bitcoincom.moonpay.io/ landing page

  • Verified New tab settings shows entry for Bitcoin.com
    image

  • Verified widget can be removed by clicking on the widget menu and selecting Hide Bitcoin.com

  • Verified widget can be removed via dashboard settings

  • Verified widget can be removed via new tab page settings

  • Verified widget is available on all supported regions

  • Verified widget is not shown for unsupported regions

  • Verified clean profile on unsupported region and then switching to supported region doesn't add the widget

  • Verified for supported regions on upgrade, widget is added to the stack automatically

Logged followup issues

ryanml added a commit that referenced this pull request Oct 3, 2020
ryanml added a commit that referenced this pull request Oct 3, 2020
Adding Bitcoin.com widget to the NTP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants