Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bitcoin.com widget to the NTP #11982

Closed
ryanml opened this issue Oct 3, 2020 · 2 comments
Closed

Add Bitcoin.com widget to the NTP #11982

ryanml opened this issue Oct 3, 2020 · 2 comments

Comments

@ryanml
Copy link
Contributor

ryanml commented Oct 3, 2020

Screen Shot 2020-09-22 at 11 15 57 AM

Screen Shot 2020-09-22 at 11 15 39 AM

Note the available regions: https://github.com/brave/brave-core/pull/6681/files#diff-99ab139e0e75cd3b8c853a30d3abb80aR14 (No US, Canada, India)

Test plan:

  1. Fresh profile
  2. Navigate to brave://newTab
  3. Ensure Bitcoin.com is available behind the Binance widget on the NTP
  4. Open up New Tab page dashboard settings, select 'More Cards'
  5. Scroll to Bitcoin.com
  6. Ensure that 'Hide' removes it from the stack, and that 'Add' adds it to the foreground
  7. Ensure that default fiat currency is 'EURO'
  8. Ensure that Fiat can be changed to CAD
  9. Ensure that the primary currency can be changed to BTC
  10. Ensure that the amount input can be changed to 100, and only acceptable numerical values, ex(1, 2, 3, 3.50, 200.50, 500)
  11. Click Buy
  12. Ensure it opens a new tab to: https://bitcoincom.moonpay.io/?currencyCode=btc&baseCurrencyCode=cad&baseCurrencyAmount=100
  13. Ensure clicking on Get the wallet here to get started opens to: https://bitcoincom.moonpay.io/
  14. Navigate to brave://settings#newTab
  15. Ensure that Bitcoin.com can be shown/hidden
@ryanml ryanml added this to the 1.15.x - Release #1 milestone Oct 3, 2020
@ryanml ryanml self-assigned this Oct 3, 2020
@ryanml
Copy link
Contributor Author

ryanml commented Oct 3, 2020

Backfilled issue, closed in: brave/brave-core#6681

@srirambv
Copy link
Contributor

srirambv commented Oct 5, 2020

Verification passed on

Brave 1.15.70 Chromium: 86.0.4240.68 (Official Build) (64-bit)
Revision ad72ee9aa8e15ed300df1238e76c7a8f4d686f97-refs/branch-heads/4240@{#1097}
OS Linux
  • Verified Bitcoin.com widget is available on a clean install and is stacked behind Binance widget
    image

  • Verified Bitcoin.com widget is available in more cards under dashboard setting and can be added or removed
    image

  • Verified EUR is the default currency selected

  • Verified able to change default currency from Bitcoin Cash (BCH) to other values in the dropdown
    image

  • Verified Fiat currency can be changed from EURO to other
    image

  • Verified https://bitcoincom.moonpay.io/?currencyCode=eth&baseCurrencyCode=eur&baseCurrencyAmount=100.2 is loaded when clicked on Buy button after entering the fiat currency value

  • Verified fiat amount input field only accepts whole values or decimal values and no string input is accepted

  • Verified entering a single decimal value is rounded of to two decimal places on the landing page

  • Verified clicking on the Buy button opens the landing page in a new tab

  • Verified Get the wallet here to get started opens to: https://bitcoincom.moonpay.io/

  • Verified New Tab Page menu under settings has Bitcoin.com entry
    image

  • Verified the widget can be disabled by

    • Widget menu
    • NTP Dashboard settings
    • NTP Menu settings (brave://settings/newTab)
  • Verified for unsupported region there is no Bitcoin.com widget in

NTP Dashboard settings New Tab Page settings
image image image

Verification passed on

Brave 1.15.70 Chromium: 86.0.4240.68 (Official Build) (64-bit)
Revision ad72ee9aa8e15ed300df1238e76c7a8f4d686f97-refs/branch-heads/4240@{#1097}
OS Windows 10 OS Version 1809 (Build 17763.1457)
  • Verified Bitcoin.com widget is available on a clean install and is stacked behind Binance widget
    image

  • Verified Bitcoin.com widget is available in more cards under dashboard setting and can be added or removed
    image

  • Verified EUR is the default currency selected
    image

  • Verified able to change default currency from Bitcoin Cash (BCH) to other values in the dropdown
    image

  • Verified Fiat currency can be changed from EURO to other
    image

  • Verified https://bitcoincom.moonpay.io/?currencyCode=ltc&baseCurrencyCode=usd&baseCurrencyAmount=75.92 is loaded when clicked on Buy button after entering the fiat currency value

  • Verified fiat amount input field only accepts whole values or decimal values and no string input is accepted

  • Verified entering a single decimal value is rounded of to two decimal places on the landing page

  • Verified clicking on the Buy button opens the landing page in a new tab

  • Verified Get the wallet here to get started opens to: https://bitcoincom.moonpay.io/

  • Verified New Tab Page menu under settings has Bitcoin.com entry

  • Verified the widget can be disabled by

    • Widget menu
    • NTP Dashboard settings
    • NTP Menu settings (brave://settings/newTab)
  • Verified for unsupported region there is no Bitcoin.com widget in

NTP Dashboard settings New Tab Page settings
image image image

Verification passed on

Brave 1.15.70 Chromium: 86.0.4240.68 (Official Build) (x86_64)
Revision ad72ee9aa8e15ed300df1238e76c7a8f4d686f97-refs/branch-heads/4240@{#1097}
OS macOS Version 10.15.7 (Build 19H2)
  • Verified Bitcoin.com widget is available on a clean install and is stacked behind Binance widget

Screenshot 2020-10-06 at 05 34 22

  • Verified Bitcoin.com widget is available in more cards under dashboard setting and can be added or removed
    image

  • Verified EUR is the default currency selected
    image

  • Verified able to change default currency from Bitcoin Cash (BCH) to other values in the dropdown
    image

  • Verified Fiat currency can be changed from EURO to other
    image

  • Verified https://bitcoincom.moonpay.io/?currencyCode=xrp&baseCurrencyCode=aud&baseCurrencyAmount=22.03 is loaded when clicked on Buy button after entering the fiat currency value

  • Verified fiat amount input field only accepts whole values or decimal values and no string input is accepted

  • Verified entering a single decimal value is rounded of to two decimal places on the landing page

  • Verified clicking on the Buy button opens the landing page in a new tab

  • Verified Get the wallet here to get started opens to: https://bitcoincom.moonpay.io/

  • Verified New Tab Page menu under settings has Bitcoin.com entry
    image

  • Verified the widget can be disabled by

    • Widget menu
    • NTP Dashboard settings
    • NTP Menu settings (brave://settings/newTab)
  • Verified for unsupported region there is no Bitcoin.com widget in

NTP Dashboard settings New Tab Page settings
image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment