Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Widget] Add messaging within widget when currency is below min value #11960

Closed
srirambv opened this issue Oct 2, 2020 · 1 comment · Fixed by brave/brave-core#6823
Closed

Comments

@srirambv
Copy link
Contributor

srirambv commented Oct 2, 2020

Description

Add messaging within widget when currency is below min value

Steps to Reproduce

  1. Open Bitcoin.com widget
  2. Enter a very low value like 0 or 0.50 for amount
  3. Click on Buy, landing page loads and adds a default value of 200. Console logs error for value below min amount
  4. In certain situation the buy modal on landing page fails to load itself

Actual result:

Default Value No Buy screen
image image

Expected result:

Should probably show min amount message on widget instead of loading the landing page and pre-populate with min amount

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.17.7 Chromium: 86.0.4240.55 (Official Build) nightly (x86_64)
Revision a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS macOS Version 10.15.7 (Build 19H2)/ Linux/ Windows 10 OS Version 1809 (Build 17763.1457)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @ryanml @rebron

@srirambv srirambv added suggestion polish Nice to have — usually related to front-end/visual tasks QA/Yes release-notes/exclude feature/widgets OS/Desktop labels Oct 2, 2020
@srirambv srirambv mentioned this issue Oct 2, 2020
32 tasks
@ryanml ryanml self-assigned this Oct 9, 2020
@ryanml ryanml added this to the 1.17.x - Nightly milestone Oct 9, 2020
ryanml added a commit to brave/brave-core that referenced this issue Oct 9, 2020
ryanml added a commit to brave/brave-core that referenced this issue Oct 9, 2020
@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.17.61 Chromium: 86.0.4240.185 (Official Build) beta (64-Bit)
Revision 37e6f852ed18086458552039ad26421aa9fc7acc-refs/branch-heads/4240@{#1377}
OS Linux
  • Verified warning message is shown when amount entered is below min value
    image

Verification passed on

Brave 1.17.61 Chromium: 86.0.4240.185 (Official Build) beta (64-Bit)
Revision 37e6f852ed18086458552039ad26421aa9fc7acc-refs/branch-heads/4240@{#1377}
OS Windows 10 OS Version 1809 (Build 17763.1518)
  • Verified warning message is shown when amount entered is below min value
    image

Verification passed on

Brave 1.17.61 Chromium: 86.0.4240.185 (Official Build) beta (x86_64)
Revision 37e6f852ed18086458552039ad26421aa9fc7acc-refs/branch-heads/4240@{#1377}
OS macOS Version 10.15.7 (Build 19H2)
  • Verified warning message is shown when amount entered is below min value
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants