Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disables password check feature. #6501

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Conversation

mkarolin
Copy link
Collaborator

Resolves brave/brave-browser#11423

Chromium change:

https://source.chromium.org/chromium/chromium/src/+/e662da68809e7b34e3defa9eb946539a8a0f7ca1

commit e662da68809e7b34e3defa9eb946539a8a0f7ca1
Author: Vasilii Sukhanov vasilii@chromium.org
Date: Wed Jun 10 12:44:20 2020 +0000

Enable 'PasswordCheck' feature on desktop by default.

Additionally the CL introduces the password check flag on Android only.

Bug: 1049177

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Fixes brave/brave-browser#11423

Chromium change:

https://source.chromium.org/chromium/chromium/src/+/e662da68809e7b34e3defa9eb946539a8a0f7ca1

commit e662da68809e7b34e3defa9eb946539a8a0f7ca1
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date:   Wed Jun 10 12:44:20 2020 +0000

    Enable 'PasswordCheck' feature on desktop by default.

    Additionally the CL introduces the password check flag on Android only.

    Bug: 1049177
@mkarolin mkarolin added this to the 1.15.x - Nightly milestone Aug 25, 2020
@mkarolin mkarolin self-assigned this Aug 25, 2020
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkarolin mkarolin merged commit 66d163c into master Aug 26, 2020
@mkarolin mkarolin deleted the maxk-remove-check-passwords branch August 26, 2020 01:27
mkarolin added a commit that referenced this pull request Aug 26, 2020
mkarolin added a commit that referenced this pull request Aug 26, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Aug 26, 2020

Verification PASSED on macOS 10.15.6 x64 using the following build:

Brave | 1.15.12 Chromium: 85.0.4183.83 (Official Build) nightly (64-bit)
-- | --
Revision | 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS | macOS Version 10.15.6 (Build 19G73)

Screen Shot 2020-08-26 at 11 32 00 AM

  • ensured that Check Password was removed from brave://settings/passwords
  • ensure that you can save passwords and they appear under brave://settings/passwords
  • ensured that you can login into websites using auto-fill from brave://settings/passwords
  • ensured that the Manage button on the modal once you've saved a password works as expected
  • ensured that viewing password works as expected once OS authentication is completed
  • ensured that clicking on "Details" works as expected
  • ensured you can remove the password from brave://settings/passwords via Remove
  • upgraded personal profile with ~50 saved passwords and ensured password auto-fill worked as expected
    • ensured that all the above cases worked on an existing profile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] remove "Check passwords" UI in settings
4 participants