Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disables password check feature (1.14.x). #6505

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

mkarolin
Copy link
Collaborator

Resolves brave/brave-browser#11423
Uplift from #6501

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@mkarolin mkarolin added this to the 1.14.x - Beta milestone Aug 26, 2020
@mkarolin mkarolin requested a review from a team August 26, 2020 01:31
@mkarolin mkarolin self-assigned this Aug 26, 2020
@kjozwiak
Copy link
Member

test-browser failed on Win x64 due to GreaselionServiceTest.ScriptInjectionWithPrecondition failing as per https://ci.brave.com/job/pr-brave-browser-maxk-remove-check-passwords-1.14.x-windows/1/execution/node/216/log/. However, this is a known intermittent issue that doesn't block uplift.

00:17:51  [  FAILED  ] GreaselionServiceTest.ScriptInjectionWithPrecondition, where TypeParam =  and GetParam() =  (2687 ms)
00:17:51  
00:17:51  [607/608] GreaselionServiceTest.ScriptInjectionWithPrecondition (2858 ms)
00:17:54  1 test failed:
00:17:54      GreaselionServiceTest.ScriptInjectionWithPrecondition (../../brave/browser/greaselion/greaselion_browsertest.cc:265)
00:17:54  null

@mkarolin does the above need to be rebased? Looks like macOS failed init as per https://ci.brave.com/job/pr-brave-browser-maxk-remove-check-passwords-1.14.x-macos/1/execution/node/104/log/.

23:55:21  1 failed patches:
23:55:21  chrome/VERSION
23:55:21    - Patch applied because: No corresponding .patchinfo file was found.
23:55:21    - Error - Program git exited with error code 1.
23:55:21  error: patch failed: chrome/VERSION:1
23:55:21  error: chrome/VERSION: patch does not apply

@mkarolin mkarolin force-pushed the maxk-remove-check-passwords-1.14.x branch from c4e460e to 32f8b36 Compare August 26, 2020 05:50
@kjozwiak
Copy link
Member

test-browser failed on Win x64 due to GreaselionServiceTest.ScriptInjectionWithPrecondition failing as per https://ci.brave.com/job/pr-brave-browser-maxk-remove-check-passwords-1.14.x-windows/2/execution/node/216/log/. However, this is a known intermittent issue and doesn't block uplift.

03:43:02  [  FAILED  ] GreaselionServiceTest.ScriptInjectionWithPrecondition, where TypeParam =  and GetParam() =  (2832 ms)
03:43:02  
03:43:02  [605/605] GreaselionServiceTest.ScriptInjectionWithPrecondition (3002 ms)
03:43:02  1 test failed:
03:43:02      GreaselionServiceTest.ScriptInjectionWithPrecondition (../../brave/browser/greaselion/greaselion_browsertest.cc:265)

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.14.x approved after deliberating with @brave/uplift-approvers. QA has also verified the PR on Nightly as per #6501 (comment).

@kjozwiak kjozwiak merged commit 26d0084 into 1.14.x Aug 26, 2020
@kjozwiak kjozwiak deleted the maxk-remove-check-passwords-1.14.x branch August 26, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants