Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disables password check feature (1.13.x). #6506

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

mkarolin
Copy link
Collaborator

Resolves brave/brave-browser#11423
Uplift from #6501

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@mkarolin mkarolin added this to the 1.13.x - Release milestone Aug 26, 2020
@mkarolin mkarolin requested a review from a team August 26, 2020 01:32
@mkarolin mkarolin self-assigned this Aug 26, 2020
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.13.x approved after deliberating with @brave/uplift-approvers. QA has also verified the PR on Nightly as per #6501 (comment).

@kjozwiak kjozwiak merged commit a45f64f into 1.13.x Aug 26, 2020
@kjozwiak kjozwiak deleted the maxk-remove-check-passwords-1.13.x branch August 26, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants