Adds an audit script that ignores dev vulnerabilities #5655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…v vulnerabilities.
- script returns 0 on success and 1 on failure - when `audit_dev_deps` is passed, return value is now passed through - updated `npm` command so that it works properly on Windows - updated error condition to return 1 instead of throwing exception
bsclifton
approved these changes
May 26, 2020
There was a problem hiding this comment.
Awesome work here! Made a few changes so that it would use return values. Let me know what you think 😄
I can help with the next step, which would be to also edit https://github.com/brave/brave-browser/blob/master/scripts/audit.js (used for builds; won't affect travis-ci)
|
Thanks for the pep8 fix w/ uplift.py; that was definitely my bad after addressing review feedback in #5639 |
bsclifton
added a commit
that referenced
this pull request
May 27, 2020
Adds an audit script that ignores dev vulnerabilities
bsclifton
added a commit
that referenced
this pull request
May 27, 2020
Adds an audit script that ignores dev vulnerabilities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#9938
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Ensure that
test-securitypasses on TravisReviewer Checklist:
After-merge Checklist:
changes has landed on.