Added support for parsing issues numbers to uplift #5639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsclifton
commented
May 23, 2020
| @@ -60,7 +60,10 @@ def initialize(self, args): | |||
| self.github_token = get_env_var('GITHUB_TOKEN') | |||
| if len(self.github_token) == 0: | |||
| try: | |||
| result = execute(['npm', 'config', 'get', 'BRAVE_GITHUB_TOKEN']).strip() | |||
| npm_cmd = 'npm' | |||
| if sys.platform.startswith('win'): | |||
There was a problem hiding this comment.
angry fist shaking at Windows
bsclifton
commented
May 23, 2020
|
|
||
| if len(issues_fixed) > 0: | ||
| for fixed in issues_fixed: | ||
| pr_body += (fixed[0] + '\n') |
There was a problem hiding this comment.
Since match is made like (resolves|fixes|etc) issue (number), fixed has a tuple with 3 items; full string match, text matched for 1st block (ex: resolves), text matched for 2nd block (ex: 12345)
NejcZdovc
reviewed
May 23, 2020
bsclifton
force-pushed
the
bsc-add-issues-to-uplift
branch
from
39be1ed to
1616985
Compare
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#3885
Tested using this test job (points at this branch):
https://ci.brave.com/view/wip/job/clifton-uplift-list-issues/
Feel free to run the job! 😄
Here's an example of how it looks:
#5638
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Reviewer Checklist:
After-merge Checklist:
changes has landed on.