Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds an audit script that ignores dev vulnerabilities (uplift to 1.9.x) #5677

Merged
merged 1 commit into from
May 28, 2020
Merged

Adds an audit script that ignores dev vulnerabilities (uplift to 1.9.x) #5677

merged 1 commit into from
May 28, 2020

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented May 27, 2020 •
edited
Loading

Uplift of #5655
Fixes brave/brave-browser#9938
Related brave/brave-browser#9982

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@bsclifton
Merge pull request #5655 from brave/audit-script
49f05d8 
Adds an audit script that ignores dev vulnerabilities
@bsclifton bsclifton added this to the 1.9.x - Release Hotfix 1 milestone May 27, 2020
@bsclifton bsclifton requested a review from a team May 27, 2020 16:40
@bsclifton bsclifton self-assigned this May 27, 2020
@bsclifton bsclifton added the CI/skip Do not run CI builds (except noplatform) label May 27, 2020
rebron
rebron approved these changes May 28, 2020
View reviewed changes
Copy link
Collaborator

@rebron rebron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. ++

@bsclifton bsclifton merged commit 81defd2 into 1.9.x May 28, 2020
@bsclifton bsclifton deleted the audit-script-1.9.x branch May 28, 2020 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebron rebron rebron approved these changes

Assignees

@bsclifton bsclifton

Labels
CI/skip Do not run CI builds (except noplatform)
Projects
None yet
Milestone
1.9.x - Release Hotfix 1
Development

Successfully merging this pull request may close these issues.
2 participants
@bsclifton @rebron