-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrates user settings to preferences #5417
Conversation
c81e2a8
to
ea7200f
Compare
9a67254
to
757a4b4
Compare
cebc935
to
d6c0998
Compare
b96d89a
to
488bf9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vendor/bat-native-ledger/src/bat/ledger/internal/state/state_util.h
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brave ads related changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iOS is good
6f08349
to
8902201
Compare
CI failed, macos (interruption), restarting |
Resolves brave/brave-browser#7024
Resolves brave/brave-browser#7101
Resolves brave/brave-browser#9547
DB schema change here https://github.com/brave/rewards/pull/8
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.