Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrates user settings to preferences #5417

Merged
merged 13 commits into from
May 18, 2020
Merged

Migrates user settings to preferences #5417

merged 13 commits into from
May 18, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Apr 29, 2020

Resolves brave/brave-browser#7024
Resolves brave/brave-browser#7101
Resolves brave/brave-browser#9547

DB schema change here https://github.com/brave/rewards/pull/8

Submitter Checklist:

Test Plan:

  • start from master
  • enable rewards
  • change values for AC settings
  • claim grant and do some tips
  • close browser
  • switch to this PR
  • start browser again
  • make sure that no data was lost (AC settings and summary report)

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc self-assigned this Apr 29, 2020
@NejcZdovc NejcZdovc force-pushed the rewards-preferences branch from c81e2a8 to ea7200f Compare May 5, 2020 06:37
@NejcZdovc NejcZdovc added the CI/skip Do not run CI builds (except noplatform) label May 5, 2020
@NejcZdovc NejcZdovc force-pushed the rewards-preferences branch 8 times, most recently from 9a67254 to 757a4b4 Compare May 13, 2020 06:51
@NejcZdovc NejcZdovc mentioned this pull request May 14, 2020
32 tasks
@NejcZdovc NejcZdovc force-pushed the rewards-preferences branch 3 times, most recently from cebc935 to d6c0998 Compare May 15, 2020 09:50
@NejcZdovc NejcZdovc marked this pull request as ready for review May 15, 2020 10:06
@NejcZdovc NejcZdovc requested a review from a team May 15, 2020 10:06
@NejcZdovc NejcZdovc removed the CI/skip Do not run CI builds (except noplatform) label May 15, 2020
@NejcZdovc NejcZdovc added this to the 1.11.x - Nightly milestone May 15, 2020
@NejcZdovc NejcZdovc force-pushed the rewards-preferences branch 2 times, most recently from b96d89a to 488bf9a Compare May 15, 2020 10:19
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

browser/ui/webui/brave_rewards_page_ui.cc Outdated Show resolved Hide resolved
@NejcZdovc NejcZdovc removed the request for review from gdregalo May 16, 2020 10:29
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brave ads related changes LGTM

Copy link
Collaborator

@kylehickinson kylehickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS is good

@NejcZdovc NejcZdovc force-pushed the rewards-preferences branch from 6f08349 to 8902201 Compare May 18, 2020 12:40
@NejcZdovc NejcZdovc added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-android Do not run CI builds for Android labels May 18, 2020
@NejcZdovc
Copy link
Contributor Author

CI failed, macos (interruption), restarting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS feature/rewards
Projects
None yet
4 participants