Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Rewards settings from JSON to Preferences #7024

Closed
tmancey opened this issue Nov 20, 2019 · 1 comment · Fixed by brave/brave-core#5417
Closed

Migrate Rewards settings from JSON to Preferences #7024

tmancey opened this issue Nov 20, 2019 · 1 comment · Fixed by brave/brave-core#5417
Assignees
@NejcZdovc
Labels
dev-concern feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.11.x - Release #1

Comments

@tmancey
Copy link
Contributor

tmancey commented Nov 20, 2019 •
edited by bsclifton
Loading

Test plan

See brave/brave-core#5417

Description

We still have some settings in ledger_state and publisher_state. This should be migrated to state api
@tmancey tmancey added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. dev-concern labels Nov 20, 2019
@tmancey tmancey mentioned this issue Nov 20, 2019
Closed
3 tasks
@tmancey tmancey removed the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Nov 23, 2019
@NejcZdovc NejcZdovc added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Dec 5, 2019
@NejcZdovc NejcZdovc removed the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Apr 10, 2020
@NejcZdovc NejcZdovc self-assigned this Apr 29, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Apr 29, 2020
@NejcZdovc
Migrates user settings to preferences
c81e2a8 
Resolves brave/brave-browser#7024
@NejcZdovc NejcZdovc mentioned this issue Apr 29, 2020
Merged
32 tasks
@NejcZdovc NejcZdovc added this to the 1.11.x - Nightly milestone May 15, 2020
@NejcZdovc NejcZdovc mentioned this issue May 22, 2020
Closed
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 30, 2020 •
edited by btlechowski
Loading

Verification passed on


Brave | 1.11.82 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
-- | --
Revision | 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS | Windows 10 OS Version 1903 (Build 18362.900)

Verified passed with

Brave | 1.11.85 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
-- | --
Revision | 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS | macOS Version 10.14.6 (Build 18G3020)

Verification passed on

Brave 1.11.89 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
Revision 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS Ubuntu 18.04 LTS

@zenparsing zenparsing mentioned this issue Jul 9, 2020
Closed
@rebron rebron changed the title Migrate user settings from JSON to Preferences Migrate Brave Rewards settings from JSON to Preferences Jul 14, 2020
@rebron rebron changed the title Migrate Brave Rewards settings from JSON to Preferences Migrate Rewards settings from JSON to Preferences Jul 14, 2020
@LaurenWags LaurenWags mentioned this issue Jul 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
dev-concern feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.11.x - Release #1
Development

Successfully merging a pull request may close this issue.

Migrates user settings to preferences brave/brave-core
6 participants
@tmancey @bsclifton @NejcZdovc @LaurenWags @btlechowski @GeetaSarvadnya