Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Update Rewards Balance Report Fetch #2512

Closed
kylehickinson opened this issue May 5, 2020 · 2 comments · Fixed by #2782
Closed

Update Rewards Balance Report Fetch #2512

kylehickinson opened this issue May 5, 2020 · 2 comments · Fixed by #2782
Assignees
@kylehickinson
Labels
enhancement Epic: Rewards QA/No release-notes/exclude
Milestone
1.21

Comments

@kylehickinson
Copy link
Collaborator

kylehickinson commented May 5, 2020 •
edited by NejcZdovc
Loading

Related PR: brave/brave-core#5417

The balance report data will be placed within the DB rather than file, this means that we cannot rely on a non-escaping closure for grabbing current months balance report.

Will need to update logic in Brave Rewards UI to account for this.

Test Case:

  • Verify that after tipping/claiming grants/etc. That the main rewards panel displays the correct values in the monthly report
@kylehickinson kylehickinson added this to the 1.17 milestone May 5, 2020
@jhreis jhreis removed this from the 1.17 milestone May 18, 2020
@NejcZdovc NejcZdovc added this to the 1.20 milestone Jun 30, 2020
@NejcZdovc
Copy link

putting in 1.20 as we landed 5417 in 1.11 on desktop

kylehickinson added a commit that referenced this issue Aug 5, 2020
@kylehickinson
Fix #2512: Update Rewards Balance Report fetch
35f098a
@kylehickinson kylehickinson mentioned this issue Aug 5, 2020
Merged
7 tasks
kylehickinson added a commit that referenced this issue Aug 5, 2020
@kylehickinson
Fix #2512: Update Rewards Balance Report fetch (#2782)
cb2af8c
@anthonypkeane
Copy link

QA will handle this with manual passes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
enhancement Epic: Rewards QA/No release-notes/exclude
Projects
None yet
Milestone
1.21
Development

Successfully merging a pull request may close this issue.

Fix #2512: Update Rewards Balance Report fetch brave/brave-ios
4 participants
@kylehickinson @jhreis @anthonypkeane @NejcZdovc