-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds virtual grant support #3918
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
force-pushed
the
grant-virtualization
branch
2 times, most recently
from
November 11, 2019 08:00
888b808
to
db671e8
Compare
NejcZdovc
commented
Nov 11, 2019
NejcZdovc
force-pushed
the
grant-virtualization
branch
9 times, most recently
from
November 13, 2019 09:00
e659e12
to
6d77656
Compare
masparrow
reviewed
Nov 13, 2019
masparrow
reviewed
Nov 13, 2019
masparrow
reviewed
Nov 13, 2019
masparrow
reviewed
Nov 13, 2019
masparrow
reviewed
Nov 13, 2019
components/brave_rewards/resources/android_page/components/pageWallet.tsx
Show resolved
Hide resolved
masparrow
reviewed
Nov 13, 2019
components/brave_rewards/resources/android_page/components/pageWallet.tsx
Show resolved
Hide resolved
masparrow
reviewed
Nov 13, 2019
components/brave_rewards/resources/android_page/reducers/promotion_reducer.ts
Show resolved
Hide resolved
masparrow
reviewed
Nov 13, 2019
...nts/brave_rewards/resources/extension/brave_rewards/background/reducers/promotion_reducer.ts
Outdated
Show resolved
Hide resolved
masparrow
reviewed
Nov 13, 2019
...nts/brave_rewards/resources/extension/brave_rewards/background/reducers/promotion_reducer.ts
Show resolved
Hide resolved
masparrow
reviewed
Nov 13, 2019
...brave_rewards/resources/extension/brave_rewards/background/reducers/rewards_panel_reducer.ts
Outdated
Show resolved
Hide resolved
masparrow
reviewed
Nov 13, 2019
masparrow
reviewed
Nov 13, 2019
masparrow
reviewed
Nov 13, 2019
components/brave_rewards/resources/page/components/pageWallet.tsx
Outdated
Show resolved
Hide resolved
masparrow
reviewed
Nov 13, 2019
masparrow
reviewed
Nov 13, 2019
components/brave_rewards/resources/page/components/settingsPage.tsx
Outdated
Show resolved
Hide resolved
Support fetch promotions giving you "finished" promotions to handle grant list UI Use main thread view context when inserting/updating promotions
Addresses iOS review feedback
NejcZdovc
force-pushed
the
grant-virtualization
branch
from
November 18, 2019 17:46
c0ec764
to
c810471
Compare
riastradh-brave
approved these changes
Nov 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should really have a less error-prone mechanism than a global API call to check for exceptions in the blinded token mechanism, but that can be done later!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#6078
Resolves brave/brave-browser#6711
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.