Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds virtual grant support #3918

Merged
merged 34 commits into from
Nov 19, 2019
Merged

Adds virtual grant support #3918

merged 34 commits into from
Nov 19, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Nov 7, 2019

Resolves brave/brave-browser#6078
Resolves brave/brave-browser#6711

Submitter Checklist:

Test Plan:

  • clean profile
  • start with dev flag
  • claim grant (from panel and in another run from the settings page)
  • make sure that details button show correct value and expiration date
  • make sure that balance in both panel and settings page was updated
  • go to verified publisher
  • tip that publisher and make sure that balance is reduced and tip is recorded in transaction history

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc self-assigned this Nov 7, 2019
@NejcZdovc NejcZdovc force-pushed the grant-virtualization branch 2 times, most recently from 888b808 to db671e8 Compare November 11, 2019 08:00
@NejcZdovc NejcZdovc added this to the 0.74.x - Nightly milestone Nov 11, 2019
@NejcZdovc NejcZdovc force-pushed the grant-virtualization branch 9 times, most recently from e659e12 to 6d77656 Compare November 13, 2019 09:00
@NejcZdovc NejcZdovc force-pushed the grant-virtualization branch from c0ec764 to c810471 Compare November 18, 2019 17:46
Copy link
Contributor

@riastradh-brave riastradh-brave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really have a less error-prone mechanism than a global API call to check for exceptions in the blinded token mechanism, but that can be done later!

@NejcZdovc NejcZdovc merged commit 2e86319 into master Nov 19, 2019
@NejcZdovc NejcZdovc deleted the grant-virtualization branch November 19, 2019 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants