Grant virtualization - Phase 1

[NejcZdovc]

Test Plan

Perform test plan from brave/brave-core#3918
Perform additional test plan from #6078 (comment)

---

In phase 1 we will not yet remove old contribution flow. We will still ping server for balance, but we will only get user funds in brave wallet back. So we will need to combine 3 things now: grants (blinded tokens), user funds (brave wallet) and external wallet (uphold). Sum of this 3 will give you total.

For contribution user will have two options on how to do things. If we will detect that you have blinded tokens we will use that. If you have only portion that you can use we will first use blinded tokens and then take user funds in brave wallet and at the last step external wallet if you have it connected. If you don't have blinded tokens we will first check user funds and then external wallet. User funds and external wallet will go through the old process for now.

[LaurenWags]

Additional Test Plan for grant virtualization:

1. Using a self-funded anon wallet, verify you are able to

   • do a one time tip
   • a monthly tip (contribution)
   • auto contribution
   • Confirm that all transactions work as expected and are reflected accurately on the BR panel and on brave://rewards.
   • Confirm wallet balance decreases accurately.
   • Confirm if you back up this wallet and restore on a clean profile your wallet balance is intact (minus any used BAT) as expected - no BAT is lost.

2. Using an anon wallet funded only via a virtual grant (such as UGP), verify you are able to

   • do a one time tip
   • a monthly tip (contribution)
   • auto contribution
   • Confirm that all transactions work as expected and are reflected accurately on the BR panel and on brave://rewards.
   • Confirm wallet balance decreases accurately.
   • Confirm if you back up this wallet and restore on a clean profile, your wallet balance is 0 since the UGP grant was virtualized.

3. Using an anon wallet funded with a mix of virtual and non-virtual BAT (such as self funded + UGP grant), verify you are able to

   • do a one time tip
   • a monthly tip (contribution)
   • auto contribution
   • Confirm that all transactions work as expected and are reflected accurately on the BR panel and on brave://rewards.
   • Confirm wallet balance decreases accurately.
   • Confirm if you back up this wallet and restore on a clean profile, only the self-funded BAT (minus any used) is restored. No UGP grant BAT is restored.

4. Using an anon wallet funded with a mix of old and new grants (such as UGP grant + old ad grant), verify you are able to

   • do a one time tip
   • a monthly tip (contribution)
   • auto contribution
   • Confirm that all transactions work as expected and are reflected accurately on the BR panel and on brave://rewards.
   • Confirm wallet balance decreases accurately.
   • Confirm if you back up this wallet and restore on a clean profile no UGP or Ad grant BAT is restored.

We should also verify that existing User Wallet functionality is still working as expected:
5. Using a fully KYC'd user wallet, verify you are able to

• do a one time tip
• a monthly tip (contribution)
• auto contribution
• Confirm that all transactions work as expected and are reflected accurately on the BR panel and on brave://rewards.
• Confirm wallet balance decreases accurately.

6. Using a connected but not KYC'd user wallet, verify you are able to

   • do a one time tip
   • a monthly tip (contribution)
   • auto contribution
   • Confirm that all transactions work as expected and are reflected accurately on the BR panel and on brave://rewards.
   • Confirm wallet balance decreases accurately.

7. Confirm "Claim" process for self-funded BAT is still working:

   • enable rewards
   • restore wallet with some self-funded BAT (not from a grant)
   • connect kyc'd uphold account
   • make sure that self funded BAT is transferred to uphold card

[LaurenWags]

Verified passed using

Brave	1.3.106 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	macOS Version 10.14.6 (Build 18G103)

• Verified test plan from Adds virtual grant support brave-core#3918
• Verified test plan from Grant virtualization - Phase 1 #6078 (comment) using staging environment:

PASS - Scenario 1: Using a self-funded anon wallet, verify you are able to

• do a one time tip
• a monthly tip (contribution)
• auto contribution
• Confirm that all transactions work as expected and are reflected accurately on the BR panel and on brave://rewards.
• Confirm wallet balance decreases accurately. (Original wallet balance was 50 BAT, it is now 43 as expected)
• Confirm if you back up this wallet and restore on a clean profile your wallet balance is intact (minus any used BAT) as expected - no BAT is lost.

PASS - Scenario 2: Using an anon wallet funded only via a virtual grant (such as UGP), verify you are able to

• do a one time tip
• a monthly tip (contribution)
• auto contribution
• Confirm that all transactions work as expected and are reflected accurately on the BR panel and on brave://rewards.
• Confirm wallet balance decreases accurately. (Original wallet balance was 17.5 BAT, it is now 0 BAT as expected)
• Confirm if you back up this wallet and restore on a clean profile, your wallet balance is 0 since the UGP grant was virtualized.

PASS - Scenario 3: Using an anon wallet funded with a mix of virtual and non-virtual BAT (such as self funded + UGP grant), verify you are able to

• do a one time tip
• a monthly tip (contribution)
• auto contribution
• Confirm that all transactions work as expected and are reflected accurately on the BR panel and on brave://rewards.
• Confirm wallet balance decreases accurately. (27+17.5=44.5 BAT to start with, wallet is now correctly at 19.5)
• Confirm if you back up this wallet and restore on a clean profile, only the self-funded BAT (minus any used) is restored. No UGP BAT is restored.

PAS - Scenario 4: Using an anon wallet funded with a mix of old and new grants (such as UGP grant + old ad grant), verify you are able to

• do a one time tip
• a monthly tip (contribution)
• auto contribution
• Confirm that all transactions work as expected and are reflected accurately on the BR panel and on brave://rewards.
• Confirm wallet balance decreases accurately. (Original balance was 21 BAT, it is now correctly 5 BAT)
• Confirm if you back up this wallet and restore on a clean profile, no UGP or Ad grant BAT is restored because they were virtualized.

PASS - Scenario 5: Using a fully KYC'd user wallet, verify you are able to

• do a one time tip
• a monthly tip (contribution)
• auto contribution
• Confirm that all transactions work as expected and are reflected accurately on the BR panel and on brave://rewards.
• Confirm wallet balance decreases accurately. (Starting balance was 103 BAT, wallet balance is now showing 87 BAT.)

Logged issue for trouble with connected but not KYC'd accounts for tip, recurring tip, AC (Scenario 6): #7999

Waiting for sandbox account to be verified - Scenario 7: Confirm "Claim" process for self-funded BAT is still working

• enable rewards
• restore wallet with some self-funded BAT (not from a grant)
• connect kyc'd uphold account or connect unverified acct and go thru KYC process
• make sure that self funded BAT is transferred to uphold card

[ RESPONSE - OnTransferAnonToExternalWallet ]
> time: 1580736511
> result: Success
> http code: 200
> response: {}
> headers accept-ranges: bytes
> headers cache-control: private
> headers content-length: 2
> headers content-type: application/json; charset=utf-8
> headers date: Mon, 03 Feb 2020 13:28:31 GMT
> headers server: Cowboy
> headers status: 200
> headers via: 1.1 varnish
> headers x-cache: MISS
> headers x-cache-hits: 0
> headers x-served-by: cache-lga21923-LGA
[ END RESPONSE ]

Verification passed on

Brave	1.3.107 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified test plan from Adds virtual grant support brave-core#3918
• Verified test plan from Grant virtualization - Phase 1 #6078 (comment) using staging environment:

PASS - Scenario 1: Using a self-funded anon wallet, verify you are able to

• do a one time tip
• a monthly tip (contribution)
• auto contribution
• Confirm that all transactions work as expected and are reflected accurately on the BR panel and on brave://rewards.
• Confirm wallet balance decreases accurately. (Original wallet balance was 25 BAT, it is now 13 as expected)
• Confirm if you back up this wallet and restore on a clean profile your wallet balance is intact (minus any used BAT) as expected - no BAT is lost.

PASS - Scenario 2: Using an anon wallet funded only via a virtual grant (such as UGP), verify you are able to

• do a one time tip
• a monthly tip (contribution)
• auto contribution
• Confirm that all transactions work as expected and are reflected accurately on the BR panel and on brave://rewards.
• Confirm wallet balance decreases accurately. (Original wallet balance was 17.5 BAT, it is now 5.5 BAT as expected)
• Confirm if you back up this wallet and restore on a clean profile, your wallet balance is 0 since the UGP grant was virtualized.

PASS - Scenario 3: Using an anon wallet funded with a mix of virtual and non-virtual BAT (such as self funded + UGP grant), verify you are able to

• do a one time tip
• a monthly tip (contribution)
• auto contribution
• Confirm that all transactions work as expected and are reflected accurately on the BR panel and on brave://rewards.
• Confirm wallet balance decreases accurately. (7+17.5=24.5 BAT to start with, wallet is now correctly at 19.5)
• Confirm if you back up this wallet and restore on a clean profile, only the self-funded BAT (minus any used) is restored. No UGP BAT is restored.
  
  

PAS - Scenario 4: Using an anon wallet funded with a mix of old and new grants (such as UGP grant + old ad grant), verify you are able to

• do a one time tip
• a monthly tip (contribution)
• auto contribution
• Confirm that all transactions work as expected and are reflected accurately on the BR panel and on brave://rewards.
• Confirm wallet balance decreases accurately. (Original balance was 20.5 BAT, it is now correctly 8.5 BAT)
• Confirm if you back up this wallet and restore on a clean profile, no UGP or Ad grant BAT is restored because they were virtualized.

PASS - Scenario 5: Using a fully KYC'd user wallet, verify you are able to

• do a one time tip
• a monthly tip (contribution)
• auto contribution
• Confirm that all transactions work as expected and are reflected accurately on the BR panel and on brave://rewards.
• Confirm wallet balance decreases accurately. (Starting balance was 20 BAT, wallet balance is now showing 13.1 BAT.)
  

Scenario 6: Encountered issue #7999 for trouble with connected accounts for tip, recurring tip, AC.

Scenario 7: Confirm "Claim" process for self-funded BAT is still working

• enable rewards
• restore wallet with some self-funded BAT (not from a grant)
• connect kyc'd uphold account or connect unverified acct and go thru KYC process
• make sure that self funded BAT is transferred to uphold card
  
  

Verification passed on

Brave	1.3.111 Chromium: 80.0.3987.85 (Official Build) (64-bit)
Revision	583b05dfa4ffc657f0f7c5cc13f53aa17c9a5bcf-refs/branch-heads/3987@{#791}
OS	Ubuntu 18.04 LTS

• Verified test plan from Adds virtual grant support brave-core#3918
• Verified test plan from Grant virtualization - Phase 1 #6078 (comment) using staging environment:

PASS - Scenario 1: Using a self-funded anon wallet, verify you are able to

PASS - Scenario 2: Using an anon wallet funded only via a virtual grant (such as UGP), verify you are able to

PASS - Scenario 3: Using an anon wallet funded with a mix of virtual and non-virtual BAT (such as self funded + UGP grant), verify you are able to

PASS - Scenario 4: Using an anon wallet funded with a mix of old and new grants (such as UGP grant + old ad grant), verify you are able to

PASS - Scenario 5: Using a fully KYC'd user wallet, verify you are able to

PASS - Scenario 6:

Scenario 7: Confirm "Claim" process for self-funded BAT is still working

• enable rewards
• restore wallet with some self-funded BAT (not from a grant)
• connect kyc'd uphold account or connect unverified acct and go thru KYC process
• make sure that self funded BAT is transferred to uphold card