We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grants::FetchGrants
If server by mistake sends unexpected value in grant.type in response to FetchGrants, then it will be resolved as ads grant and presented to a user so. https://github.com/brave/brave-core/blob/master/components/brave_rewards/browser/rewards_notification_service_impl.cc#L337. It would be good if we have a check for acceptable grants types when parsing json.
FetchGrants
The Ads grants is presented on UI. Observable on Android.
Check for acceptable grants types when parsing json response. Ignore corrupted response or log it and add to statistics sent back to Brave.
The text was updated successfully, but these errors were encountered:
this one should be addressed with brave/brave-core#3918
Sorry, something went wrong.
NejcZdovc
Successfully merging a pull request may close this issue.
Description
If server by mistake sends unexpected value in grant.type in response to
FetchGrants
, then it will be resolved as ads grant and presented to a user so.https://github.com/brave/brave-core/blob/master/components/brave_rewards/browser/rewards_notification_service_impl.cc#L337.
It would be good if we have a check for acceptable grants types when parsing json.
Steps to Reproduce
FetchGrants
.Actual result:
The Ads grants is presented on UI.
Observable on Android.
Expected result:
Check for acceptable grants types when parsing json response. Ignore corrupted response or log it and add to statistics sent back to Brave.
Reproduces how often:
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: