Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKUs SDK: regenerate the request id when moving from Active to Generated #21847

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

evq
Copy link
Member

@evq evq commented Jan 31, 2024

Resolves brave/brave-browser#35742

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@evq evq marked this pull request as ready for review January 31, 2024 23:27
@evq evq requested a review from a team as a code owner January 31, 2024 23:27
@evq evq requested a review from husobee January 31, 2024 23:27
@evq evq merged commit fad2178 into master Feb 1, 2024
22 checks passed
@evq evq deleted the regen-request-id branch February 1, 2024 19:51
@github-actions github-actions bot added this to the 1.64.x - Nightly milestone Feb 1, 2024
brave-builds added a commit that referenced this pull request Feb 2, 2024
brave-builds added a commit that referenced this pull request Feb 2, 2024
@stephendonner
Copy link
Contributor

stephendonner commented Feb 2, 2024

Verification IN-PROGRESS using

Brave | 1.64.43 Chromium: 121.0.6167.139 (Official Build) nightly (x86_64)
-- | --
Revision | 190a1d5dbad671a0994283b793d4e66e98b82371
OS | macOS Version 14.4 (Build 23E5180j)

Testing on-hold due to brave/brave-browser#35742 (comment)

Account was set up around 1:33pm PDT, Friday, February 2, 2024

Steps:

  1. installed 1.64.43
  2. launched Brave
  3. loaded account.bravesoftware.com
  4. entered basic auth
  5. logged in using feb2@mailinator.com (new account)
  6. clicked Browse plans
  7. clicked Buy now for Leo Premium
  8. filled out Stripe test credit-card details
example example example example example example
Screen Shot 2024-02-02 at 1 33 02 PM Screen Shot 2024-02-02 at 1 33 04 PM Screen Shot 2024-02-02 at 1 33 10 PM Screen Shot 2024-02-02 at 1 34 44 PM Screen Shot 2024-02-02 at 1 34 59 PM Screen Shot 2024-02-02 at 1 35 31 PM

kjozwiak pushed a commit that referenced this pull request Feb 7, 2024
…ted (uplift to 1.63.x) (#21871)

* Uplift of #21847 (squashed) to beta

* SKUs SDK: regenerate request id on submit conflict from server (#21887)

* SKUs SDK: regenerate request id on submit conflict from server

* add error if item type is not time limited v2

---------

Co-authored-by: eV <8796196+evq@users.noreply.github.com>
kjozwiak pushed a commit that referenced this pull request Feb 7, 2024
…ted (uplift to 1.62.x) (#21872)

* Uplift of #21847 (squashed) to release

* SKUs SDK: regenerate request id on submit conflict from server (#21887)

* SKUs SDK: regenerate request id on submit conflict from server

* add error if item type is not time limited v2

---------

Co-authored-by: eV <8796196+evq@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SKU SDK: Credentials refresh is forced due to request id conflict
4 participants