Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SKUs SDK: regenerate the request id when moving from Active to Generated (uplift to 1.62.x) #21872

Merged
merged 2 commits into from
Feb 7, 2024
Merged

SKUs SDK: regenerate the request id when moving from Active to Generated (uplift to 1.62.x) #21872

merged 2 commits into from
Feb 7, 2024

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Feb 2, 2024 •
edited by kjozwiak
Loading

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner February 2, 2024 03:54
@brave-builds brave-builds added this to the 1.62.x - Release #4 milestone Feb 2, 2024
@brave-builds brave-builds self-assigned this Feb 2, 2024
@evq
SKUs SDK: regenerate request id on submit conflict from server (#21887)
efd12f2 
* SKUs SDK: regenerate request id on submit conflict from server

* add error if item type is not time limited v2
kjozwiak
kjozwiak approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.62.x approved 👍 QA has verified the PR on Nightly using 1.64.x as per #21887 (comment).

@kjozwiak kjozwiak merged commit 8d34eec into 1.62.x Feb 7, 2024
13 checks passed
@kjozwiak kjozwiak deleted the pr21847_regen-request-id_1.62.x branch February 7, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.62.x - Release #4
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @evq