Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Select Send Loading Skeletons #20026

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

Douglashdaniel
Copy link
Contributor

Description

Adds a Loading Skeleton to the Select a token to send modal while balances are loading

Resolves brave/brave-browser#32641

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Go to the Send tab and open the Select a token to send modal
  2. You should see a Loading Skeleton while balances are being loaded.
Screen.Recording.24.mov

@Douglashdaniel Douglashdaniel requested a review from a team as a code owner September 6, 2023 21:35
@Douglashdaniel Douglashdaniel self-assigned this Sep 6, 2023
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Sep 6, 2023
@Douglashdaniel Douglashdaniel force-pushed the select-send-loading-skeletons branch from 9dec315 to a5e7ac8 Compare September 6, 2023 21:57
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel merged commit 4aeac73 into master Sep 6, 2023
@Douglashdaniel Douglashdaniel deleted the select-send-loading-skeletons branch September 6, 2023 23:32
@github-actions github-actions bot added this to the 1.60.x - Nightly milestone Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add loading state indicator in select token screen
3 participants