Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loading state indicator in select token screen #32641

Closed
srirambv opened this issue Aug 31, 2023 · 1 comment · Fixed by brave/brave-core#20026
Closed

Add loading state indicator in select token screen #32641

srirambv opened this issue Aug 31, 2023 · 1 comment · Fixed by brave/brave-core#20026
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop polish Nice to have — usually related to front-end/visual tasks QA Pass-Win64 QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

Description

Add loading state indicator in select token screen

Steps to Reproduce

  1. Restore a wallet with token balance
  2. Lock wallet if its already unlocked
  3. Go to Send screen
  4. Click on Select token
  5. Shows No available tokens message for a few seconds before loading the balance

Actual result:

brave_IIrJIaptnn.mp4

Expected result:

Should add a loading state indicator and also maybe rename No available tokens to No tokens availabale

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.58.108 Chromium: 116.0.5845.114 (Official Build) beta (64-bit)
Revision f08ffbe3ce0069ad8207b9d2d7dee38afcccc1b9
OS Windows 11 Version 22H2 (Build 22621.2215)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Maybe
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @Douglashdaniel @josheleonard @kleantzogu

@srirambv srirambv added polish Nice to have — usually related to front-end/visual tasks QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Aug 31, 2023
@srirambv srirambv added this to Web3 Aug 31, 2023
@Douglashdaniel Douglashdaniel self-assigned this Sep 1, 2023
@Douglashdaniel Douglashdaniel added the front-end-change This task is a front end task and doesn't need any C++ changes label Sep 1, 2023
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Sep 1, 2023
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Sep 6, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Sep 6, 2023
@brave-builds brave-builds added this to the 1.60.x - Nightly milestone Sep 6, 2023
@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.60.102 Chromium: 118.0.5993.96 (Official Build) beta (64-bit)
Revision 3598a9fc6b7752181feb25caa131bc386d6d054c
OS Windows 11 Version 22H2 (Build 22621.2428)
  • Verified steps from issue description and brave/brave-core#20026
  • Verified loading state indicator is shown on Send screen when token balance is being fetched
32641.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop polish Nice to have — usually related to front-end/visual tasks QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants