Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 114.0.5735.26 to Chromium 114.0.5735.35 #18548

Merged
merged 6 commits into from
May 23, 2023
Merged

Upgrade from Chromium 114.0.5735.26 to Chromium 114.0.5735.35 #18548

merged 6 commits into from
May 23, 2023

Conversation

emerick
Copy link
Contributor

@emerick emerick commented May 19, 2023

Resolves brave/brave-browser#30461

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@emerick emerick added this to the 1.53.x - Nightly milestone May 19, 2023
@emerick emerick requested a review from a team May 19, 2023 13:50
@emerick emerick self-assigned this May 19, 2023
@emerick emerick requested review from a team as code owners May 19, 2023 13:50
@github-actions github-actions bot added CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-network-audit Run network-audit labels May 19, 2023
mkarolin
mkarolin approved these changes May 19, 2023
View reviewed changes
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@emerick emerick requested a review from a team as a code owner May 19, 2023 18:47
@emerick emerick requested a review from simonhong May 19, 2023 18:48
@emerick emerick force-pushed the 114.0.5735.35_master branch 2 times, most recently from 456a200 to 750da77 Compare May 19, 2023 19:07
@emerick emerick force-pushed the 114.0.5735.35_master branch from a6c005c to 450a812 Compare May 20, 2023 02:52
@kjozwiak kjozwiak merged commit 8b549fe into master May 23, 2023
@kjozwiak kjozwiak deleted the 114.0.5735.35_master branch May 23, 2023 18:32
@kjozwiak kjozwiak mentioned this pull request May 24, 2023
Merged
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonhong simonhong simonhong approved these changes

@mkarolin mkarolin mkarolin approved these changes

Assignees

@emerick emerick

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-network-audit Run network-audit
Projects
None yet
Milestone
1.56.x - Release
Development

Successfully merging this pull request may close these issues.

Upgrade from Chromium 114.0.5735.26 to Chromium 114.0.5735.35
5 participants
@emerick @simonhong @mkarolin @kjozwiak @brave-builds