Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 114.0.5735.26 to Chromium 114.0.5735.35 #30461

Closed
emerick opened this issue May 19, 2023 · 6 comments · Fixed by brave/brave-core#18548
Closed

Upgrade from Chromium 114.0.5735.26 to Chromium 114.0.5735.35 #30461

emerick opened this issue May 19, 2023 · 6 comments · Fixed by brave/brave-core#18548

Comments

@emerick
Copy link
Contributor

emerick commented May 19, 2023

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/114.0.5735.26..114.0.5735.35?pretty=fuller&n=10000

QA tests:

  • Check branding items
  • Check for version bump

Additional checks:

  • No specific code changes in Brave (only line number changes in patches)
@kjozwiak
Copy link
Member

The above requires 1.52.110 or higher for 1.52.x verification 👍

@kjozwiak
Copy link
Member

kjozwiak commented May 24, 2023

Quick overview of the work remaining re: affected areas due to C114 on the following platforms:

Platforms that only require a spot check due to already completing full check of the affected areas mentioned via #29600 (comment).

Platforms that still need to check/verify the affected areas due to C114 changes as per #29600 (comment).

  • Linux - Still needs to check affected areas

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 24, 2023
@LaurenWags
Copy link
Member

LaurenWags commented May 24, 2023

Verified with

Brave | 1.52.110 Chromium: 114.0.5735.35 (Official Build) (x86_64)
-- | --
Revision | 2295354895fa3652ae47b651481831484f16d1ff-refs/branch-heads/5735@{#713}
OS | macOS Version 13.4 (Build 22F66)
Intel

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 24, 2023
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.52.110 Chromium: 114.0.5735.35 (Official Build) (64-bit)
-- | --
Revision | 2295354895fa3652ae47b651481831484f16d1ff-refs/branch-heads/5735@{#713}
OS | Windows 11 Version 22H2 (Build 22621.1702)

image

@kjozwiak
Copy link
Member

kjozwiak commented May 25, 2023

Verification PASSED on Pixel 6 running Android 14 using the following build(s):

Brave | 1.52.112 Chromium: 114.0.5735.35 (Official Build) (32-bit)
--- | ---
Revision | 2295354895fa3652ae47b651481831484f16d1ff-refs/branch-heads/5735@{#713}
OS | Android 13; Build/UPB2.230407.014; 33; UpsideDownCake
Example Example
Screenshot_20230525-145154 Screenshot_20230525-145213

Verification PASSED on Samsung Galaxy Tab S8 Ultra running Android 13 using the following build(s):

Brave | 1.52.112 Chromium: 114.0.5735.35 (Official Build) (32-bit)
--- | ---
Revision | 2295354895fa3652ae47b651481831484f16d1ff-refs/branch-heads/5735@{#713}
OS | Android 13; Build/TP1A.220624.014; 33; REL
Example Example
Screenshot_20230525_150203_Brave Screenshot_20230525_150215_Brave

@kjozwiak
Copy link
Member

Labelling QA/No & release-notes/exclude in favour of #30588 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment