-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ads status header to all search.brave.com requests. #16023
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diracdeltas
reviewed
Nov 18, 2022
tmancey
reviewed
Dec 14, 2022
tmancey
reviewed
Dec 14, 2022
tmancey
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1e73741
to
580ad09
Compare
remusao
approved these changes
Dec 19, 2022
36b8db3
to
1744cb7
Compare
bridiver
reviewed
Jan 10, 2023
iefremov
reviewed
Jan 17, 2023
iefremov
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI/run-network-audit
Run network-audit
potential-layer-violation-fixes
This PR touches a BUILD.gn file with check_includes=false
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
X-Brave-Ads-Enabled: 1
header is added to search.brave.commain frame
navigation requests if Brave Ads are enabled. It was implemented here: brave/brave-browser#25430Now server search side requires to get
X-Brave-Ads-Enabled: 1
header with xhr/fetch requests also. And for simplicity, it was decided to send the header with all search.brave.com requests if Brave Ads are enabled.The
X-Brave-Ads-Enabled
header description: https://github.com/brave/brave-browser/wiki/Custom-Headers#x-brave-ads-enabledResolves brave/brave-browser#26812
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Run Brave browser with fresh profile
X-Brave-Ads-Enabled
header is not set in requests to search.brave.comX-Brave-Ads-Enabled
header is not set in requests to search.brave.com and that a search result ad can be viewedX-Brave-Ads-Enabled
header is not set in requests to search.brave.com and that a search result ad can be viewedEnable Brave Private Ads
X-Brave-Ads-Enabled: 1
header is presented in requests to search.brave.comX-Brave-Ads-Enabled: 1
header is presented in requests to search.brave.com and that a search result ad is not shownX-Brave-Ads-Enabled: 1
header is presented in requests to search.brave.com and that a search result ad is not shownDisable Brave Private Ads
X-Brave-Ads-Enabled
header is not set in requests to search.brave.comX-Brave-Ads-Enabled
header is not set in requests to search.brave.com and that a search result ad can be viewedX-Brave-Ads-Enabled
header is not set in requests to search.brave.com and that a search result ad can be viewedRun browser in Private mode
X-Brave-Ads-Enabled
header is not set in requests to search.brave.comX-Brave-Ads-Enabled
header is not set in requests to search.brave.com and that a search result ad can be viewedX-Brave-Ads-Enabled
header is not set in requests to search.brave.com and that a search result ad can be viewedAlso need to make sure that this logic is working for dev/staging Brave Search environments. The list of supported hosts is here: hosts