-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Brave Ads status header to search.brave.com calls #25430
Comments
Verification passed on
Verified test plan from brave/brave-core#15147 https://search.brave.com/Clean profile Ads enabled Ads disabled |
Removing |
Requires |
Verification passed on
Verified test plan from brave/brave-core#15147 https://search.brave.com/Clean profile Ads enabled Ads disabled Ads enabled - Private window https://search.brave.software/Clean profile Ads enabled Ads disabled Verification passed on
Verified test plan from brave/brave-core#15147 https://search.brave.com/Clean profile Ads enabled Ads disabled |
Verification passed on Brave v1.45.129 on Samsung Galaxy Tab S5e (Android 11.0) Verified test plan from brave/brave-core#15147 https://search.brave.com/Clean profile Ads enabled Ads disabled |
Verified on
Clean profile
Ads Enabled
Ads Disabled
|
Description
In preparation for Brave Ads on Brave Search, it is helpful for the Brave Search backend to understand whether the requesting browser has Brave Ads enabled. As such we should add the header
X-Brave-Ads-Enabled: 1
to any call to Brave Search (and it's associated dev/staging environments) whether originating from the main search box or the Omnibox.This can hopefully use some of the same mechanisms that have been used in the past on this, e.g. https://github.com/brave/brave-browser/wiki/Custom-Headers. When the work is complete, please add an appropriate description to this page: https://github.com/brave/brave-browser/wiki/Custom-Headers.
The text was updated successfully, but these errors were encountered: