Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add channel icons & update how channel cards look to be in line with the updated design. #15524

Merged
merged 3 commits into from
Oct 20, 2022

Conversation

fallaciousreasoning
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning commented Oct 19, 2022

Resolves brave/brave-browser#26115
Partially Resolves brave/brave-browser#25988

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Enable the Brave News V2 flag
  2. When customizing Brave News, channels should have the new icons.

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Oct 19, 2022
@fallaciousreasoning fallaciousreasoning changed the title Add channel icons & update how channel cards look Add channel icons & update how channel cards look to be in line with the updated design. Oct 19, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Contributor

@sangwoo108 sangwoo108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! LGTM.

@stephendonner
Copy link
Contributor

Verified PASSED using

Steps:

  1. installed 1.47.47
  2. launched Brave
  3. clicked on Skip welcome tour
  4. opened brave://flags
  5. set brave://flags/#brave-news-v2 to Enabled
  6. clicked on Relaunch
  7. opened a new-tab page
  8. clicked on Customize
  9. clicked on Brave News
  10. clicked on Turn on Brave News
  11. clicked on Show more beneath Channels

Confirmed the new icon set is in

Dark Light
Screenshot 2022-11-05 at 2 43 57 AM Screenshot 2022-11-05 at 2 44 30 AM

petemill pushed a commit that referenced this pull request Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
4 participants