Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News customize 2.0 - Channel images and follow button changes #25988

Closed
petemill opened this issue Oct 13, 2022 · 4 comments · Fixed by brave/brave-core#15524
Closed

News customize 2.0 - Channel images and follow button changes #25988

petemill opened this issue Oct 13, 2022 · 4 comments · Fixed by brave/brave-core#15524
Assignees
Labels

Comments

@petemill
Copy link
Member

@aguscruiz has provided a design which uses the same icons as the mobile design for channels, both on cards and favicons.
image

https://www.figma.com/proto/SDcE22eeUsV2uc4dy3NwaC/Onboarding?page-id=728%3A57643&node-id=753%3A63473&viewport=-1602%2C515%2C1.41&scaling=min-zoom&starting-point-node-id=740%3A67470

https://www.figma.com/file/SDcE22eeUsV2uc4dy3NwaC/Onboarding?node-id=753%3A63473

Other changes, from @aguscruiz:

Side panel:

  • the unfollow button appears on hover, not always present.
    List of sources:
  • the follow button appears on hover too
  • If you click follow, then the "unfollow" button remains there in case you change your mind
  • There's a subtle drop-shadow on hover
@petemill
Copy link
Member Author

Update: the "unfollow" button should always be visible. The "follow" button should only show on hover. This is to make it easier to glance at which results are already-following.

@fallaciousreasoning
Copy link

I think we can close this now you've fixed the follow button and I've fixed the channel cards in #15524

@kjozwiak kjozwiak added this to the 1.46.x - Beta milestone Nov 8, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Nov 8, 2022

The above will require 1.46.100 or higher for 1.46.x verification 👍

@kjozwiak kjozwiak added the QA/Yes label Nov 8, 2022
@stephendonner
Copy link

Verification PASSED using

Brave 1.46.100 Chromium: 107.0.5304.91 (Official Build) dev (x86_64)
Revision 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS macOS Version 11.7.1 (Build 20G918)

Steps:

  1. installed 1.46.100
  2. launched Brave
  3. clicked Skip welcome tour
  4. opened brave://flags
  5. set brave://flags/#brave-news-v2 to Enabled
  6. clicked Relaunch
  7. opened a new-tab page
  8. scrolled down
  9. clicked on Show Brave News
  10. now, clicked on Customize
  11. typed gamespot
  12. hovered over Follow
  13. clicked on Follow
  14. moused away from the Gamespot card
  15. hovered over Gamespot card again
  16. confirmed I saw Unfollow
  17. hovered over the Unfollow button
  18. clicked Unfollow

Confirmed the following various default and hover states for the Follow and Unfollow buttons and channel cards.

Follow, default Follow, hover state Followed state Unfollow, card hover state Unfollow, button hover state
Screen Shot 2022-11-08 at 1 10 47 PM Screen Shot 2022-11-08 at 1 10 50 PM Screen Shot 2022-11-08 at 1 15 49 PM Screen Shot 2022-11-08 at 1 19 02 PM Screen Shot 2022-11-08 at 1 19 06 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants