Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YT appearance on Brave Panel #1478

Closed
wants to merge 1 commit into from
Closed

YT appearance on Brave Panel #1478

wants to merge 1 commit into from

Conversation

SergeyZhukovsky
Copy link
Member

Submitter Checklist:

Closes brave/brave-browser#3135

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@SergeyZhukovsky
Copy link
Member Author

@NejcZdovc does that look good from a desktop side? Desktop YT is broken I think as well without that.

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Jan 29, 2019

@SergeyZhukovsky I will fix this issue in this PR #1457. I think we can close this one. On desktop youtube is working it just doesn't show AC %.

@NejcZdovc
Copy link
Contributor

closing as it was fixed in #1457

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants