Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import passwords for Opera/Edge/Vivaldi on macOS (uplift to 1.43.x) #14663

Merged
merged 2 commits into from
Aug 20, 2022

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Aug 16, 2022

Uplift of #14526
Resolves brave/brave-browser#24130

Uplift of #14559
Resolves brave/brave-browser#24343
Resolves brave/brave-browser#24578

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner August 16, 2022 18:22
@brave-builds brave-builds self-assigned this Aug 16, 2022
@brave-builds brave-builds added this to the 1.43.x - Beta milestone Aug 16, 2022
@bsclifton bsclifton changed the title Import passwords for Opera (uplift to 1.43.x) Import passwords for Opera/Edge/Vivaldi on macOS (uplift to 1.43.x) Aug 17, 2022
@stephendonner
Copy link
Contributor

stephendonner commented Aug 19, 2022

Verification PASSED using

Brave 1.44.57 Chromium: 104.0.5112.102 (Official Build) nightly (x86_64)
Revision 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS macOS Version 11.6.8 (Build 20G730)

Case 1: Vivaldi (brave/brave-browser#24578) - PASSED

Followed my original steps to reproduce from brave/brave-browser#24578.

example example example example example example example
Screen Shot 2022-08-19 at 11 20 12 AM Screen Shot 2022-08-19 at 11 22 29 AM Screen Shot 2022-08-19 at 11 22 35 AM Screen Shot 2022-08-19 at 11 22 41 AM Screen Shot 2022-08-19 at 11 22 53 AM Screen Shot 2022-08-19 at 11 23 49 AM Screen Shot 2022-08-19 at 11 26 51 AM

Confirmed all saved passwords were successfully imported, and viable

Case 2: Opera (brave/brave-browser#24130) - PASSED

Pre-requisite: install latest Opera, and seed with passwords

I used:

  • facebook.com
  • fill.dev
  • github.com
  • account.google.com (Gmail)

Steps:

  1. installed 1.44.57
  2. launched Brave
  3. tested the following:
  • brave://welcome , 2nd slide, Import from...
  • Brave -> Import Bookmarks and Settings...
  • "hamburger" menu -> Bookmarks -> Import Bookmarks and Settings...
  • brave://settings/importData directly
  1. after importing, loaded brave://settings/passwords?search=passwords

Confirmed all saved passwords were successfully imported, and viable

example example example example example example
Screen Shot 2022-08-19 at 12 39 36 PM Screen Shot 2022-08-19 at 2 04 30 PM Screen Shot 2022-08-19 at 2 04 44 PM Screen Shot 2022-08-19 at 2 05 02 PM Screen Shot 2022-08-19 at 2 05 13 PM Screen Shot 2022-08-19 at 12 49 54 PM

Case 3: Edge (brave/brave-browser#24343) - PASSED

Followed my original steps to reproduce from brave/brave-browser#24343.

example example example example example
Screen Shot 2022-08-19 at 1 05 02 PM Screen Shot 2022-08-19 at 1 05 59 PM Screen Shot 2022-08-19 at 1 06 10 PM Screen Shot 2022-08-19 at 1 06 22 PM Screen Shot 2022-08-19 at 1 06 56 PM

Confirmed all saved passwords were successfully imported, and viable

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.43.x approved 👍 QA has verified the PR on Nightly as per #14663 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants