Add delay before reconnect to network service in IpfsDnsResolverImpl. #14510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrliou
reviewed
Aug 10, 2022
yrliou
reviewed
Aug 10, 2022
Resolves brave/brave-browser#24461 This should lower CPU usage in case the network service fails to start.
yrliou
approved these changes
Aug 12, 2022
| @@ -12,6 +12,8 @@ | |||
|
|
|||
| namespace ipfs { | |||
|
|
|||
| constexpr base::TimeDelta kRetryDelay = base::Seconds(1); | |||
There was a problem hiding this comment.
add missing header include: #include "base/time/time.h"
Verified
|
| Brave | 1.44.62 Chromium: 104.0.5112.102 (Official Build) nightly (x86_64) |
|---|---|
| Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478} |
| OS | macOS Version 11.6.8 (Build 20G730) |
Steps:
- installed
1.44.62 - launched Brave
- loaded
brave://ipfs-internals - clicked on
Install and start - opened
Window->Task Manager - selected
Utility: Network Service - clicked on
End Process - opened
brave://settings/securityand made sureWith Cloudflare (1.1.1.1)was selected - loaded
ipns://en.wikipedia-on-ipfs.org
Confirmed it loaded ipns://en.wikipedia-on-ipfs.org/wiki/ with a new Utility: Network Service process (Old: 6420, New: 6285)
| example | example | example | example | example |
|---|---|---|---|---|
 |
 |
 |
 |
 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#24461
This should lower CPU usage in case the network service fails to start.
Test Plan:
Check that IPFS DNS override works after kill network service process. (you can find it by "--utility-sub-type=network.mojom.NetworkService" flag):
Kill network service process, go to DNS settings, select something like Cloudflare option, load ipfs:// url, Check that IPFS daemon uses Cloudflare requests.