Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pin to task method from first run dialog #14520

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Aug 8, 2022

fix brave/brave-browser#24363

This is f/u PR for #14311.
I accidently omitted calling pin method while rebasing from above PR.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

fix brave/brave-browser#24363

This is f/u PR for #14311.
I accidently omitted calling pin method while rebasing from above PR.
@simonhong simonhong self-assigned this Aug 8, 2022
Copy link
Contributor

@sangwoo108 sangwoo108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhong simonhong merged commit f97eca6 into master Aug 8, 2022
@simonhong simonhong deleted the call_pin_to_taskbar_api_from_first_run branch August 8, 2022 06:09
@simonhong simonhong added this to the 1.44.x - Nightly milestone Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow up of #24241 - Pin to taskbar from first run dialog
2 participants