Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up of #24241 - Pin to taskbar from first run dialog #24363

Closed
MadhaviSeelam opened this issue Aug 1, 2022 · 2 comments · Fixed by brave/brave-core#14520
Closed

Follow up of #24241 - Pin to taskbar from first run dialog #24363

MadhaviSeelam opened this issue Aug 1, 2022 · 2 comments · Fixed by brave/brave-core#14520

Comments

@MadhaviSeelam
Copy link

Description

Follow up of #24241 - Pin to taskbar from first run dialog

Steps to Reproduce

  1. Follow steps from Pin to taskbar from first run dialog #24241 (comment)

Actual result:

Brave is not pinned to task bar after selecting to be a default browser
image

Expected result:

Brave should be pinned to taskbar

Ex1 Ex2
image image

Reproduces how often:

Easily

Brave version (brave://version info)

Brave 1.44.12 Chromium: 104.0.5112.69 (Official Build) nightly (64-bit)
Revision 7ce2902023c722af8564068e6b26e934b83fd774-refs/branch-heads/5112@{#1213}
OS Windows 11 Version 21H2 (Build 22000.795)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? N/A
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@simonhong @rebron

simonhong added a commit to brave/brave-core that referenced this issue Aug 8, 2022
fix brave/brave-browser#24363

This is f/u PR for #14311.
I accidently omitted calling pin method while rebasing from above PR.
@simonhong
Copy link
Member

Set QA/No because this can be verified from #24241

@simonhong
Copy link
Member

@MadhaviSeelam Please check again when nightly build has fix for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants