Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin to taskbar from first run dialog #24241

Closed
simonhong opened this issue Jul 25, 2022 · 2 comments · Fixed by brave/brave-core#14311
Closed

Pin to taskbar from first run dialog #24241

simonhong opened this issue Jul 25, 2022 · 2 comments · Fixed by brave/brave-core#14311
Assignees
@simonhong
Labels
OS/Desktop OS/Windows QA/No release-notes/exclude
Milestone
1.44.x - Release

Comments

@simonhong
Copy link
Member

simonhong commented Jul 25, 2022 •
edited
Loading

This is subtask of #24054

Description

Pin Brave to task bar when user sets Brave as a default browser from first run dialog

Steps to Reproduce

  1. Launch with clean profile
  2. Agree to set as a default browser
  3. Check brave is also pinned to taskbar
@simonhong simonhong self-assigned this Jul 25, 2022
@simonhong simonhong mentioned this issue Jul 25, 2022
Closed
@simonhong simonhong mentioned this issue Jul 25, 2022
Merged
25 tasks
simonhong added a commit to brave/brave-core that referenced this issue Jul 25, 2022
@simonhong
Pin Brave to taskbar from FirstRun dialog
ecaaa9d 
fix brave/brave-browser#24241

When user set Brave as a default browser from FirstRun dialog,
try to pin to taskbar.
@simonhong simonhong added this to the 1.44.x - Nightly milestone Jul 27, 2022
@MadhaviSeelam
Copy link

MadhaviSeelam commented Jul 30, 2022 •
edited
Loading

Verification Complete using

Brave 1.44.9 Chromium: 104.0.5112.69 (Official Build) nightly (64-bit)
Revision 7ce2902023c722af8564068e6b26e934b83fd774-refs/branch-heads/5112@{#1213}
OS Windows 11 Version 21H2 (Build 22000.795)

Issue is still reproducible in 1.44.9 & 1.44.12 and logged a follow up issue - #24363

@MadhaviSeelam MadhaviSeelam mentioned this issue Aug 1, 2022
Closed
@simonhong simonhong added QA/No and removed QA/Yes labels Aug 23, 2022
@simonhong
Copy link
Member Author

Set QA/No as this feature will be disabled via #24870
Instead, we can verify this when #24054 is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
OS/Desktop OS/Windows QA/No release-notes/exclude
Projects
None yet
Milestone
1.44.x - Release
Development

Successfully merging a pull request may close this issue.

Pin Brave to taskbar from FirstRun dialog brave/brave-core
3 participants
@rebron @simonhong @MadhaviSeelam