Add Pin to taskbar option to first run dialog and settings

[simonhong]

Description

When user set Brave as a default browser, pin Brave to taskbar also.

Steps to reproduce

1. Launch Brave with clean profile
2. Click Set Default button after checking pin to taskbar
3. Check shortcut is pinned to taskbar
4. Load brave://settings/getStarted and check settings shows as pinned
5. Unpin from taskbar and reload brave://settings/getStarted and click Pin button
6. Check pinned to taskbar

Brave version (brave://version info)

Version/Channel Information:

• Can you reproduce this issue with the current release? n/a
• Can you reproduce this issue with the beta channel? n/a
• Can you reproduce this issue with the nightly channel? n/a

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? n/a
• Does the issue resolve itself when disabling Brave Rewards? n/a
• Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

See related: #24055

FF - https://github.com/mozilla/gecko-dev/blob/master/browser/components/shell/nsWindowsShellService.cpp

[MadhaviSeelam]

Verification PASSED using

Brave | 1.46.80 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
-- | --
Revision | a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS | Windows 11 Version 21H2 (Build 22000.1098)

Case 1: Pin Brave to taskbar via Pin to taskbar check box in the first run dialog

1. Install 1.46.80
2. launch Brave
3. check the check box for Pin to taskbar on the first run dialog
4. click Set Brave as default button
5. confirmed Brave browser is pinned to taskbar
6. closed the browser
7. relaunched by clicking the Brave icon pinned to taskbar
8. open brave://settings/getStarted
9. Brave is your default browser text is shown brave://settings/getStarted
10. Brave is already pinned text is shown in Brave://settings/getStarted

Confirmed Brave is successfully pinned to taskbar

step 3-4	step 5	step 7	step 8-10

Case 2: Unpin Brave from the taskbar and Pin it from brave://settings/getStarted

1. continue from Case 1
   • Brave icon pinned to taskbar
2. unpin from taskbar and reload brave://settings/getStarted
3. Pin button is displayed
4. click Pin button again
5. Brave is already pinned text is shown in Brave://settings/getStarted

Confirmed Brave successfully pinned to taskbar

step 1	step 1	step 3	step 5

Case 3: Do not check Pin to taskbar check box but click Set Brave as default button on first run dialog

1. new profile
2. unpin Brave if it's pinned to taskbar
3. launch Brave
4. do not check the check box for Pin to taskbar on the first run dialog
5. click Set Brave as default button
6. click Skip welcome tour
7. Brave is not pinned to the taskbar
8. open brave://settings/getStarted
9. Brave is your default browser text is shown brave://settings/getStarted
10. Pin button is shown in brave://settings/getStarted
11. click on Pin button

Confirmed Brave successfully pinned to taskbar

step 4-5	step 7	step 11	result

Case 4: Pin Brave via brave://settings/getStarted when non-Brave browser set as a default in Windows settings

1. new profile
2. unpin Brave from taskbar if pinned to it
3. set Firefox a default browser
4. launch Brave
5. click (x) to close the first run dialog
6. click on Skip welcome tour
7. close the browser and relaunch browser
8. click Set as default button on the Infobar
9. Infobar gets dismissed
10. open brave://settings/getStarted
11. Brave is your default browser text is shown brave://settings/getStarted
12. Pin button is shown in brave://settings/getStarted
13. click on Pin button

Confirmed Brave successfully pinned to taskbar

step 3	step 5	step 8	step 9	step 12-13	result

Case 5: Upgrade from 1.45.x (beta)--->1.46.x(beta)

Pre-requisite: same channels for the upgrade (i.e. beta-->beta)

1. Install 1.45.104
2. launch Brave
3. Click Set Brave as default on the first run dialog
4. open brave://settings/getStarted and confirmed it shows Brave is your default browser text
5. upgrade to 1.46.81
6. go to brave://settings/getStarted
7. Click Pin button

Confirmed Brave successfully pinned to taskbar

step 1	step 3	step 5	step 6-7	result

Bugs filed:

• Should set as pinned state only when it's actually pinned #26301

[LaurenWags]

@GeetaSarvadnya could you please give this one a check on Win 10 as well? once you're done you can add the QA Pass-Win64 label 👍🏻

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.46.90 Chromium: 107.0.5304.91 (Official Build) beta (64-bit)
-- | --
Revision | 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS | Windows 10 Version 21H2 (Build 19044.2130)

• Verified the STR from the description
• Logged Brave is pinned to the taskbar when brave is NOT pinned explicitly via the first run dialog #26542

Case 1: Pin Brave to taskbar via Pin to taskbar check box in the first run dialog

1. Install 1.46.90
2. launch Brave
3. check the check box for Pin to taskbar on the first run dialog
4. click Set Brave as default button
5. confirmed Brave browser is pinned to taskbar
6. closed the browser
7. relaunched by clicking the Brave icon pinned to taskbar
8. open brave://settings/getStarted
9. Brave is your default browser text is shown brave://settings/getStarted
10. Brave is already pinned text is shown in Brave://settings/getStarted

Confirmed Brave is successfully pinned to taskbar

step 3-4	step 5	step 8-10

Case 2: Unpin Brave from the taskbar and Pin it from brave://settings/getStarted

1. continue from Case 1
   • Brave icon pinned to taskbar
2. unpin from taskbar and reload brave://settings/getStarted
3. Pin button is displayed
4. click Pin button again
5. Brave is already pinned text is shown in Brave://settings/getStarted

Confirmed Brave successfully pinned to taskbar

step 1	step 3	step 5

Case 3: Do not check Pin to taskbar check box but click Set Brave as default button on first run dialog

1. new profile
2. unpin Brave if it's pinned to taskbar
3. launch Brave
4. do not check the check box for Pin to taskbar on the first run dialog
5. click Set Brave as default button
6. click Skip welcome tour
7. Brave is not pinned to the taskbar
8. open brave://settings/getStarted
9. Brave is your default browser text is shown brave://settings/getStarted
10. Pin button is shown in brave://settings/getStarted
11. click on Pin button

Confirmed Brave successfully pinned to taskbar

step 4-5	step 7	step 11	result

Case 4: Pin Brave via brave://settings/getStarted when non-Brave browser set as a default in Windows settings

1. new profile
2. unpin Brave from taskbar if pinned to it
3. set Firefox a default browser
4. launch Brave
5. click (x) to close the first run dialog
6. click on Skip welcome tour
7. close the browser and relaunch browser
8. click Set as default button on the Infobar
9. Infobar gets dismissed
10. open brave://settings/getStarted
11. Brave is your default browser text is shown brave://settings/getStarted
12. Pin button is shown in brave://settings/getStarted
13. click on Pin button

Confirmed Brave successfully pinned to taskbar

---

Upgrade Profile

Case 1: Install 1.45.x, set brave as default then upgrade the profile 1.46.x_PASSED

Pre-requisite: same channels for the upgrade (i.e. beta-->beta)

1. Install 1.45.104
2. launch Brave
3. Click Set Brave as default on the first run dialog
4. open brave://settings/getStarted and confirmed it shows Brave is your default browser text
5. upgrade to 1.46.81
6. go to brave://settings/getStarted
7. Click Pin button

Confirmed Brave successfully pinned to taskbar

step 1	step 3	step 5	step 6-8

Case 2: Install 1.45.x, click on may be later then upgrade the profile 1.46.x_PASSED

Pre-requisite: same channels for the upgrade (i.e. beta-->beta)

1. Install 1.45.104
2. launch Brave
3. Click May be later on the first run dialog
4. Open brave://settings/help and then upgrade the profile
5. Upgrade to 1.46.x
6. Go to brave://settings/getStarted and confirmed Pin text is shown
7. Click Pin button
8. Confirmed brave is pinned to task bar and text "Brave is already pinned" is shown in the brave://settings/getStarted

Case 3: Install 1.45.x, click on `x` in the first run dialog and pin to taskbar then upgrade the profile 1.46.x_PASSED

Pre-requisite: same channels for the upgrade (i.e. beta-->beta)

1. Install 1.45.104
2. launch Brave
3. Click x on the first run dialog
4. Pin to taskbar by using the taskbar context menu
5. Upgrade to 1.46.81
6. Go to brave://settings/getStarted
7. Ensured Brave is already pinned text is shown and right click on the taskbar menu shows the Unpin from taskbar menu option as expected
8. Unpin from the taskbar
9. Reload brave://settings/getStarted
10. Pin option is shown, click on it
11. Confirmed brave is pinned and same is shown in the taskbar as well as in brave://settings/getStarted

Example	Example	Example	Example	Example	Example