-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sardine on ramp provider #14353
Merged
Merged
Add sardine on ramp provider #14353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
CI/storybook-url
Deploy storybook and provide a unique URL for each build
label
Jul 27, 2022
muliswilliam
force-pushed
the
add-sardine-token-list
branch
2 times, most recently
from
August 1, 2022 10:06
aadfc90
to
1dd5afb
Compare
muliswilliam
force-pushed
the
add-sardine-token-list
branch
from
August 2, 2022 11:20
eb8375c
to
1836f53
Compare
A Storybook has been deployed to preview UI for the latest push |
josheleonard
approved these changes
Aug 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Frontend ++
…al instead of bool
* Add case for Sardine in BlockchainRegistry::GetBuyUrl * Move BlockchainRegistry::GetBuyUrl -> AssetRatioService::GetBuyUrl because it has easy access to the API request helper instance
muliswilliam
force-pushed
the
add-sardine-token-list
branch
from
August 4, 2022 15:18
6c358d1
to
188a6f3
Compare
nvonpentz
approved these changes
Aug 4, 2022
A Storybook has been deployed to preview UI for the latest push |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#24356
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Portal
Sardine.on.ramp.mov
Panel
Sardine.Panel.mov