Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sardine on ramp provider #14353

Merged
merged 14 commits into from
Aug 4, 2022
Merged

Add sardine on ramp provider #14353

merged 14 commits into from
Aug 4, 2022

Conversation

muliswilliam
Copy link
Contributor

@muliswilliam muliswilliam commented Jul 27, 2022

Resolves brave/brave-browser#24356

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Portal

Sardine.on.ramp.mov

Panel

Sardine.Panel.mov

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jul 27, 2022
@muliswilliam muliswilliam force-pushed the add-sardine-token-list branch 2 times, most recently from aadfc90 to 1dd5afb Compare August 1, 2022 10:06
@muliswilliam muliswilliam marked this pull request as ready for review August 1, 2022 10:12
@muliswilliam muliswilliam requested review from a team and bridiver as code owners August 1, 2022 10:12
@muliswilliam muliswilliam force-pushed the add-sardine-token-list branch from eb8375c to 1836f53 Compare August 2, 2022 11:20
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Contributor

@josheleonard josheleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frontend ++

@muliswilliam muliswilliam force-pushed the add-sardine-token-list branch from 6c358d1 to 188a6f3 Compare August 4, 2022 15:18
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@muliswilliam muliswilliam merged commit 8f198b7 into master Aug 4, 2022
@muliswilliam muliswilliam deleted the add-sardine-token-list branch August 4, 2022 19:01
@github-actions github-actions bot added this to the 1.44.x - Nightly milestone Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sardine Integration - Frontend
4 participants