Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sardine Integration - Frontend #24356

Closed
muliswilliam opened this issue Aug 1, 2022 · 1 comment · Fixed by brave/brave-core#14353
Closed

Sardine Integration - Frontend #24356

muliswilliam opened this issue Aug 1, 2022 · 1 comment · Fixed by brave/brave-core#14353
Assignees
@muliswilliam
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.44.x - Release

Comments

@muliswilliam
Copy link

muliswilliam commented Aug 1, 2022 •
edited
Loading

  • Add sardine token list
  • Add sardine as an onramp provider in the buy tab
@muliswilliam muliswilliam self-assigned this Aug 1, 2022
@muliswilliam muliswilliam added front-end-change This task is a front end task and doesn't need any C++ changes release-notes/include QA/Yes labels Aug 1, 2022
@muliswilliam muliswilliam moved this from Backlog to In Review in Web3 Aug 1, 2022
@muliswilliam muliswilliam mentioned this issue Aug 1, 2022
Merged
25 tasks
Repository owner moved this from In Review to Done in Web3 Aug 4, 2022
@brave-builds brave-builds added this to the 1.44.x - Nightly milestone Aug 4, 2022
@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label Aug 31, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.44.97 Chromium: 106.0.5249.40 (Official Build) (64-bit)
Revision 4d5f098fca6ab7f4b6b7c240be3d9593c2357709-refs/branch-heads/5249@{#531}
OS Linux
  • Verified steps from brave/brave-core#14353
  • Verified Sardine is available as on-ramp provider for buy
  • Verified able to submit a buy via Sardine on both Buy widget and via panel
24356.mp4

Verification passed on

Brave 1.44.97 Chromium: 106.0.5249.40 (Official Build) (64-bit)
Revision 4d5f098fca6ab7f4b6b7c240be3d9593c2357709-refs/branch-heads/5249@{#531}
OS Windows 11 Version 21H2 (Build 22000.978)
  • Verified steps from brave/brave-core#14353
  • Verified Sardine is available as on-ramp provider for buy
  • Verified able to submit a buy via Sardine on both Buy widget and via panel
24356.mp4

Verification passed on

Brave 1.44.97 Chromium: 106.0.5249.40 (Official Build) (arm64)
Revision 4d5f098fca6ab7f4b6b7c240be3d9593c2357709-refs/branch-heads/5249@{#531}
OS macOS Version 12.4 (Build 21F79)
  • Verified steps from brave/brave-core#14353
  • Verified Sardine is available as on-ramp provider for buy
  • Verified able to submit a buy via Sardine on both Buy widget and via panel
24356.mov

@kjozwiak kjozwiak mentioned this issue Sep 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.44.x - Release
Development

Successfully merging a pull request may close this issue.

Add sardine on ramp provider brave/brave-core
4 participants
@srirambv @LaurenWags @brave-builds @muliswilliam