Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): implement DApps decrypt screen #13868

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

Pavneet-Sing
Copy link

@Pavneet-Sing Pavneet-Sing commented Jun 20, 2022

Resolves brave/brave-browser#23260

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Enable "Desktop site" check from the menu

Same as desktop flow from PR 12386

  1. Go to https://inb0x.life/ and click Connect
  2. Unlock and Connect your wallet
  3. Click Activate and Sign the message prompt
  4. Click Generate Secured inb0x Key and then click Provide in the Public Encryption Key panel.
  5. Click Send New Message and then send a test message to another Wallet address.
  6. Lock your Wallet and then refresh the page.
  7. Unlock your Wallet and then click Connect
  8. Click Activate and then Sign the message prompt
  9. Wait for the Decrypt Message panel, Click Decrypt message to verify functionality.
  10. Click Allow and it should sign you back in to pick up where you left off.
public-key-decrypt.mp4

Additional:

@Pavneet-Sing Pavneet-Sing added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jun 20, 2022
@Pavneet-Sing Pavneet-Sing self-assigned this Jun 20, 2022
@Pavneet-Sing Pavneet-Sing added this to the 1.42.x - Nightly milestone Jun 20, 2022
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@Pavneet-Sing Pavneet-Sing merged commit 97011de into master Jun 21, 2022
@Pavneet-Sing Pavneet-Sing deleted the implement-dapps-decrypt-screen branch June 21, 2022 08:26
Pavneet-Sing pushed a commit that referenced this pull request Jun 21, 2022
Pavneet-Sing pushed a commit that referenced this pull request Jun 21, 2022
@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 12 running 1.42.15 x64 Nightly build

  • Verified test plan from PR
  • Verified Encrypt and Decrypt panels are shown correctly
13868.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DApps: Add decrypt request screen
3 participants