-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wallet): Built Out Encryption Key Panel UI #12386
Conversation
A Storybook has been deployed to preview UI for the latest push |
@@ -241,6 +241,12 @@ | |||
<message name="IDS_BRAVE_WALLET_SIGN_WARNING_TITLE" desc="Sign panel risk title">Sign at your own risk</message> | |||
<message name="IDS_BRAVE_WALLET_SIGN_TRANSACTION_MESSAGE_TITLE" desc="Sign panel message title">Message</message> | |||
<message name="IDS_BRAVE_WALLET_SIGN_TRANSACTION_BUTTON" desc="Sign panel sign button">Sign</message> | |||
<message name="IDS_BRAVE_WALLET_PROVIDE_ENCRYPTION_KEY_TITLE" desc="Provide Encryption Key Panel Title">A DApp is requesting your public encryption key</message> | |||
<message name="IDS_BRAVE_WALLET_PROVIDE_ENCRYPTION_KEY_DESCRIPTION" desc="Provide Encryption Key Panel Details"><ph name="SITE_ORIGIN"><ex>https://app.skiff.org</ex>$1</ph> is requesting your wallets public encryption key. If you consent to providing this key, the site will be able to compose encrypted messages to you.</message> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wallet's ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to access these functions using deep links? like ws:// for metamask? |
Description
Built out the
Encryption Key Panel
UIrequest
orread
request
will be displayed when a dapp is requesting yourPublic Encryption Key
read
will be displayed when a dapp is asking permission to read yourEncrypted Message
note: (This is just the build out of the UI, backend functionality will be integrated in these 2 issues brave/brave-browser#19275 , brave/brave-browser#19276)
Resolves brave/brave-browser#21177
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Request Encryption Key Panel (Demo):
![Screen Shot 2022-02-23 at 2 51 41 PM](https://user-images.githubusercontent.com/40611140/155416498-2a049f19-84c4-4195-820c-a35a7b1d1c50.png)
Allow Reading Encrypted Message Panel (Demo):
![Screen Shot 2022-02-23 at 2 49 55 PM](https://user-images.githubusercontent.com/40611140/155416608-f072aff6-cbec-4950-b165-3448b106e081.png)
Allow Reading Encrypted Message Decrypted Panel (Demo):
![Screen Shot 2022-02-23 at 2 50 04 PM](https://user-images.githubusercontent.com/40611140/155416734-d03c2e17-8a7c-4681-8ff2-4f1dfbf027db.png)
Test Plan
Connect
Activate
andSign
the message promptGenerate Secured inb0x Key
and then clickProvide
in thePublic Encryption Key
panel.Send New Message
and then send a test message to anotherWallet address
.Wallet
and then refresh the page.Wallet
and then clickConnect
Activate
and thenSign
the message promptDecrypt Message
panel, ClickDecrypt message
to verify functionality.Allow
and it should sign you back in to pick up where you left off.Screen.Recording.2022-04-25.at.1.48.49.PM.mov