Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): Built Out Encryption Key Panel UI #12386

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

Douglashdaniel
Copy link
Contributor

@Douglashdaniel Douglashdaniel commented Feb 23, 2022

Description

Built out the Encryption Key Panel UI

  1. This panel has 2 states request or read
  • request will be displayed when a dapp is requesting your Public Encryption Key
  • read will be displayed when a dapp is asking permission to read your Encrypted Message

note: (This is just the build out of the UI, backend functionality will be integrated in these 2 issues brave/brave-browser#19275 , brave/brave-browser#19276)

Resolves brave/brave-browser#21177

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Request Encryption Key Panel (Demo):
Screen Shot 2022-02-23 at 2 51 41 PM

Allow Reading Encrypted Message Panel (Demo):
Screen Shot 2022-02-23 at 2 49 55 PM

Allow Reading Encrypted Message Decrypted Panel (Demo):
Screen Shot 2022-02-23 at 2 50 04 PM

Test Plan

  1. Go to https://inb0x.life/ and click Connect
  2. Unlock and Connect your wallet
  3. Click Activate and Sign the message prompt
  4. Click Generate Secured inb0x Key and then click Provide in the Public Encryption Key panel.
  5. Click Send New Message and then send a test message to another Wallet address.
  6. Lock your Wallet and then refresh the page.
  7. Unlock your Wallet and then click Connect
  8. Click Activate and then Sign the message prompt
  9. Wait for the Decrypt Message panel, Click Decrypt message to verify functionality.
  10. Click Allow and it should sign you back in to pick up where you left off.
Screen.Recording.2022-04-25.at.1.48.49.PM.mov

@Douglashdaniel Douglashdaniel requested a review from a team as a code owner February 23, 2022 22:12
@Douglashdaniel Douglashdaniel self-assigned this Feb 23, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Feb 23, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@@ -241,6 +241,12 @@
<message name="IDS_BRAVE_WALLET_SIGN_WARNING_TITLE" desc="Sign panel risk title">Sign at your own risk</message>
<message name="IDS_BRAVE_WALLET_SIGN_TRANSACTION_MESSAGE_TITLE" desc="Sign panel message title">Message</message>
<message name="IDS_BRAVE_WALLET_SIGN_TRANSACTION_BUTTON" desc="Sign panel sign button">Sign</message>
<message name="IDS_BRAVE_WALLET_PROVIDE_ENCRYPTION_KEY_TITLE" desc="Provide Encryption Key Panel Title">A DApp is requesting your public encryption key</message>
<message name="IDS_BRAVE_WALLET_PROVIDE_ENCRYPTION_KEY_DESCRIPTION" desc="Provide Encryption Key Panel Details"><ph name="SITE_ORIGIN"><ex>https://app.skiff.org</ex>$1</ph> is requesting your wallets public encryption key. If you consent to providing this key, the site will be able to compose encrypted messages to you.</message>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wallet's ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devYonz
Copy link

devYonz commented Feb 3, 2023

Is it possible to access these functions using deep links? like ws:// for metamask?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dapp UI for requesting a public key and for decrypting ciphers
5 participants