Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cr99 follow up] Disable paper-ripple effect in settings UI. (uplift to 1.36.x) #12400

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

mkarolin
Copy link
Collaborator

Fixes brave/brave-browser#21256
Uplift of #12385

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin requested a review from a team February 24, 2022 19:58
@mkarolin mkarolin self-assigned this Feb 24, 2022
[Cr99 follow up] Disable paper-ripple effect in settings UI.
@mkarolin mkarolin force-pushed the pr12385_maxk-cr99-fup-disable-paper-ripple_1.36.x branch from acae2c7 to bf1f257 Compare February 24, 2022 22:25
@kjozwiak kjozwiak added this to the 1.36.x - Release milestone Feb 25, 2022
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.36.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #12385 (comment).

@kjozwiak kjozwiak merged commit 9caf334 into 1.36.x Feb 25, 2022
@kjozwiak kjozwiak deleted the pr12385_maxk-cr99-fup-disable-paper-ripple_1.36.x branch February 25, 2022 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants