Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cr99 follow up] Disable paper-ripple effect in settings UI. #12385

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

mkarolin
Copy link
Collaborator

Fixes brave/brave-browser#21256

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin requested a review from a team as a code owner February 23, 2022 21:50
@mkarolin mkarolin self-assigned this Feb 23, 2022
@mkarolin mkarolin force-pushed the maxk-cr99-fup-disable-paper-ripple branch from 1af6d1a to 700f09a Compare February 24, 2022 16:26
@mkarolin mkarolin requested review from emerick and removed request for a team February 24, 2022 16:26
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emerick emerick self-requested a review February 24, 2022 18:57
@mkarolin
Copy link
Collaborator Author

Windows CI failed on dist-delta step which is unrelated to this PR.

@mkarolin mkarolin merged commit 3206137 into master Feb 24, 2022
@mkarolin mkarolin deleted the maxk-cr99-fup-disable-paper-ripple branch February 24, 2022 19:45
@mkarolin mkarolin added this to the 1.38.x - Nightly milestone Feb 24, 2022
brave-builds pushed a commit that referenced this pull request Feb 24, 2022
mkarolin added a commit that referenced this pull request Feb 24, 2022
[Cr99 follow up] Disable paper-ripple effect in settings UI.
@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.38.4 Chromium: 99.0.4844.45 (Official Build) nightly (64-bit)
-- | --
Revision | edbc0b8343c7b10fddb0e1b4efb280b0f6e38cab-refs/branch-heads/4844@{#788}
OS | Windows 11 Version 21H2 (Build 22000.527)

Went through the STR/Cases outlined via brave/brave-browser#21256 (comment) as per the following:

  • reproduced the issue using 1.38.1 Chromium: 99.0.4844.45
  • ensured that clicking on the menu items under brave://settings didn't trigger any unexpected animations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings animation is carried over from chrome
3 participants