Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage Your Wallet copy update (0.61) #1178

Merged
merged 1 commit into from
Dec 21, 2018
Merged

Manage Your Wallet copy update (0.61) #1178

merged 1 commit into from
Dec 21, 2018

Conversation

NejcZdovc
Copy link
Contributor

Resolves brave/brave-browser#2693

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc
Merge pull request #1177 from josephjguerra/patch-1
a72f348 
Manage Your Wallet copy update
@NejcZdovc NejcZdovc self-assigned this Dec 21, 2018
@NejcZdovc NejcZdovc requested a review from ryanml December 21, 2018 21:46
@NejcZdovc NejcZdovc mentioned this pull request Dec 21, 2018
Merged
18 tasks
@NejcZdovc NejcZdovc merged commit 1c1af3a into master Dec 21, 2018
@NejcZdovc NejcZdovc deleted the copy-master branch December 21, 2018 21:49
@bbondy bbondy added this to the 0.61.x - Nightly milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanml ryanml ryanml approved these changes

Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards
Projects
None yet
Milestone
0.61.x - Release
Development

Successfully merging this pull request may close these issues.

small typo in Manage Your Wallet copy
3 participants
@NejcZdovc @ryanml @bbondy