Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small typo in Manage Your Wallet copy #2693

Closed
josephjguerra opened this issue Dec 21, 2018 · 1 comment · Fixed by brave/brave-core#1178
Closed

small typo in Manage Your Wallet copy #2693

josephjguerra opened this issue Dec 21, 2018 · 1 comment · Fixed by brave/brave-core#1178

Comments

@josephjguerra
Copy link

Description

Small copy typo on Manage Your Wallet screen. Currently says: "It's probably safest..." with a backslash. Remove the \ so it reads: "It's probably safest..."

Steps to Reproduce

  1. chrome://rewards/#
  2. Click the gear cog at top right near Your wallet
  3. See the error in the copy at the bottom

Actual result:

It's probably safest

Expected result:

It's probably safest...

Reproduces how often:

Every time

Brave version (brave://version info)

Version 0.58.16 Chromium: 71.0.3578.98 (Official Build) (64-bit)

Brave 0.58.16 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Mac OS X
JavaScript V8 7.1.302.3

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

not sure

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@btlechowski
Copy link

btlechowski commented Jan 29, 2019

Verification passed on

Brave 0.60.17 Chromium: 72.0.3626.64 (Official Build) dev (64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Windows 7

image

Verification PASSED on macOS 10.14.2 x64 using the following build:

Brave 0.60.18 Chromium: 72.0.3626.71 (Official Build) beta(64-bit)
Revision f52ccad2a6a3c65fc9e0c591a517ceab1198dac0-refs/branch-heads/3626@{#763}
OS Mac OS X

screen shot 2019-01-29 at 6 29 18 pm

Verification passed on

Brave 0.60.26 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Linux

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment