Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage Your Wallet copy update #1177

Merged
merged 1 commit into from
Dec 21, 2018
Merged

Manage Your Wallet copy update #1177

merged 1 commit into from
Dec 21, 2018

Conversation

josephjguerra
Copy link

@josephjguerra josephjguerra commented Dec 21, 2018

remove the backslash from It's...: It's probably safest to write

Resolves brave/brave-browser#2693

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

remove the backslash from It\'s...:  It's probably safest to write
@NejcZdovc
Copy link
Contributor

@josephjguerra would be awesome if you could create an issue for this PR here https://github.com/brave/brave-browser/issues so that we can link them together. If not just let me know and I can create it for you. Thank you

@josephjguerra
Copy link
Author

josephjguerra commented Dec 21, 2018

added issue: brave/brave-browser#2693 @NejcZdovc Thank you

@NejcZdovc NejcZdovc merged commit 0a68e67 into brave:0.60.x Dec 21, 2018
NejcZdovc added a commit that referenced this pull request Dec 21, 2018
Manage Your Wallet copy update
@NejcZdovc
Copy link
Contributor

master (0.61) #1178
0.60 0a68e67

@NejcZdovc
Copy link
Contributor

@josephjguerra thank you for the PR. 🎉 For some reason I missed that this PR was not targeted against master, so I needed to create a follow up #1178

@bbondy bbondy added this to the 0.60.x - Dev milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants